Fix missing backwards compatibility layer for water_heater supported_features #107091

bdraco · 2024-01-04T10:50:51Z

Proposed change

Fix missing backwards compatibility layer for water_heater supported_features

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

…eatures

home-assistant · 2024-01-04T10:50:58Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (water_heater) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of water_heater can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign water_heater Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

elupus

Looks good once tests pass

bdraco · 2024-01-04T10:53:14Z

thanks

…features (#107091)

…to v2024.1.1 (#290) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.0` -> `2024.1.1` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.1.1`](https://github.com/home-assistant/core/releases/tag/2024.1.1) [Compare Source](home-assistant/core@2024.1.0...2024.1.1) - Enable strict typing for airthings_ble ([@cdce8p] - [#106815]) ([airthings_ble docs]) - Fix qBittorrent torrent count when empty ([@finder39] - [#106903]) ([qbittorrent docs]) - Bump dropmqttapi to 1.0.2 ([@pfrazer] - [#106978]) ([drop_connect docs]) (dependency) - bump openwebifpy to 4.0.3 ([@autinerd] - [#106593]) ([enigma2 docs]) (dependency) - Close stale connections (Airthings BLE) ([@LaStrada] - [#106748]) ([airthings_ble docs]) - Bump openwebifpy to 4.0.4 ([@autinerd] - [#107000]) ([enigma2 docs]) (dependency) - Get Shelly RPC device `gen` from config entry data ([@bieniu] - [#107019]) ([shelly docs]) - Fix missing backwards compatiblity layer for humidifier supported_features ([@bdraco] - [#107026]) ([humidifier docs]) - Use async_register in streamlabswater ([@joostlek] - [#107060]) ([streamlabswater docs]) - Fix data access in streamlabs water ([@joostlek] - [#107062]) ([streamlabswater docs]) - Fix mobile_app cloudhook creation ([@edenhaus] - [#107068]) ([mobile_app docs]) - Deduplicate handling of duplicated constants ([@emontnemery] - [#107074]) - Fix missing backwards compatibility layer for water_heater supported_features ([@bdraco] - [#107091]) ([water_heater docs]) - Bump habluetooth to 2.0.2 ([@bdraco] - [#107097]) ([bluetooth docs]) (dependency) - Include deprecated constants in wildcard imports ([@emontnemery] - [#107114]) - Update frontend to [`2024010`](https://github.com/home-assistant/core/commit/20240104).0 ([@bramkragten] - [#107155]) ([frontend docs]) - Bump Orvibo to 1.1.2 ([@emericklaw] - [#107162]) ([orvibo docs]) (dependency) - Bump aiohomekit to 3.1.2 ([@bdraco] - [#107177]) ([homekit_controller docs]) (dependency) - Bump to PyTado 0.17.3 ([@erwindouna] - [#107181]) ([tado docs]) (dependency) - Fix switch states in AVM FRITZ!Box Tools ([@mib1185] - [#107183]) ([fritz docs]) - Hotfix cache logic bug in Tessie ([@Bre77] - [#107187]) ([tessie docs]) - Disable IPv6 in the opower integration to fix AEP utilities ([@tronikos] - [#107203]) ([opower docs]) - Fix entity property cache creation arguments ([@ppetru] - [#107221]) - Use supported_features_compat in update.install service ([@ludeeus] - [#107224]) ([update docs]) - Bump zwave-js-server-python to 0.55.3 ([@raman325] - [#107225]) ([zwave_js docs]) (dependency) [#106593]: home-assistant/core#106593 [#106748]: home-assistant/core#106748 [#106815]: home-assistant/core#106815 [#106903]: home-assistant/core#106903 [#106970]: home-assistant/core#106970 [#106978]: home-assistant/core#106978 [#107000]: home-assistant/core#107000 [#107019]: home-assistant/core#107019 [#107026]: home-assistant/core#107026 [#107060]: home-assistant/core#107060 [#107062]: home-assistant/core#107062 [#107068]: home-assistant/core#107068 [#107074]: home-assistant/core#107074 [#107091]: home-assistant/core#107091 [#107097]: home-assistant/core#107097 [#107114]: home-assistant/core#107114 [#107155]: home-assistant/core#107155 [#107162]: home-assistant/core#107162 [#107177]: home-assistant/core#107177 [#107181]: home-assistant/core#107181 [#107183]: home-assistant/core#107183 [#107187]: home-assistant/core#107187 [#107203]: home-assistant/core#107203 [#107221]: home-assistant/core#107221 [#107224]: home-assistant/core#107224 [#107225]: home-assistant/core#107225 [@Bre77]: https://github.com/Bre77 [@LaStrada]: https://github.com/LaStrada [@autinerd]: https://github.com/autinerd [@bdraco]: https://github.com/bdraco [@bieniu]: https://github.com/bieniu [@bramkragten]: https://github.com/bramkragten [@cdce8p]: https://github.com/cdce8p [@edenhaus]: https://github.com/edenhaus [@emericklaw]: https://github.com/emericklaw [@emontnemery]: https://github.com/emontnemery [@erwindouna]: https://github.com/erwindouna [@finder39]: https://github.com/finder39 [@frenck]: https://github.com/frenck [@joostlek]: https://github.com/joostlek [@ludeeus]: https://github.com/ludeeus [@mib1185]: https://github.com/mib1185 [@pfrazer]: https://github.com/pfrazer [@ppetru]: https://github.com/ppetru [@raman325]: https://github.com/raman325 [@tronikos]: https://github.com/tronikos [airthings_ble docs]: https://www.home-assistant.io/integrations/airthings_ble/ [bluetooth docs]: https://www.home-assistant.io/integrations/bluetooth/ [drop_connect docs]: https://www.home-assistant.io/integrations/drop_connect/ [enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/ [fritz docs]: https://www.home-assistant.io/integrations/fritz/ [frontend docs]: https://www.home-assistant.io/integrations/frontend/ [homekit_controller docs]: https://www.home-assistant.io/integrations/homekit_controller/ [humidifier docs]: https://www.home-assistant.io/integrations/humidifier/ [mobile_app docs]: https://www.home-assistant.io/integrations/mobile_app/ [opower docs]: https://www.home-assistant.io/integrations/opower/ [orvibo docs]: https://www.home-assistant.io/integrations/orvibo/ [qbittorrent docs]: https://www.home-assistant.io/integrations/qbittorrent/ [shelly docs]: https://www.home-assistant.io/integrations/shelly/ [streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/ [tado docs]: https://www.home-assistant.io/integrations/tado/ [tessie docs]: https://www.home-assistant.io/integrations/tessie/ [update docs]: https://www.home-assistant.io/integrations/update/ [water_heater docs]: https://www.home-assistant.io/integrations/water_heater/ [zwave_js docs]: https://www.home-assistant.io/integrations/zwave_js/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/290 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

bdraco added 2 commits January 4, 2024 00:44

Fix missing backwards compatiblity layer for water_heater supported_f…

bd0f9dc

…eatures

improve test

02498d9

bdraco added this to the 2024.1.1 milestone Jan 4, 2024

home-assistant bot added bugfix cla-signed core has-tests integration: water_heater small-pr PRs with less than 30 lines. Quality Scale: internal labels Jan 4, 2024

bdraco mentioned this pull request Jan 4, 2024

Fix missing backwards compatiblity layer for humidifier supported_features #107026

Merged

20 tasks

improve test

1f9319b

bdraco marked this pull request as ready for review January 4, 2024 10:52

bdraco requested a review from a team as a code owner January 4, 2024 10:52

elupus approved these changes Jan 4, 2024

View reviewed changes

bdraco merged commit 1a08bcc into dev Jan 4, 2024
53 checks passed

bdraco deleted the water_heater_back_compat branch January 4, 2024 12:21

adamherbert mentioned this pull request Jan 4, 2024

Error adding entities for domain water_heater with platform ge_home simbaja/ha_gehome#217

Closed

larsdunemark mentioned this pull request Jan 4, 2024

Water heater dhw1 not available since HA Update to 2024.1.0 bosch-thermostat/home-assistant-bosch-custom-component#362

Closed

jonoberheide mentioned this pull request Jan 4, 2024

HA 2024.1.0 seems to break water_heater entities jlvaillant/intellicenter#71

Open

frenck added the cherry-picked label Jan 5, 2024

frenck pushed a commit that referenced this pull request Jan 5, 2024

Fix missing backwards compatibility layer for water_heater supported_…

d600b76

…features (#107091)

frenck mentioned this pull request Jan 5, 2024

2024.1.1 #107239

Merged

This was referenced Jan 5, 2024

Tank heater not supported speleolontra/daikin_residential_altherma#214

Closed

2024.1 issues speleolontra/daikin_residential_altherma#213

Closed

github-actions bot locked and limited conversation to collaborators Jan 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing backwards compatibility layer for water_heater supported_features #107091

Fix missing backwards compatibility layer for water_heater supported_features #107091

bdraco commented Jan 4, 2024 •

edited

Loading

home-assistant bot commented Jan 4, 2024

elupus left a comment

bdraco commented Jan 4, 2024

Fix missing backwards compatibility layer for water_heater supported_features #107091

Fix missing backwards compatibility layer for water_heater supported_features #107091

Conversation

bdraco commented Jan 4, 2024 • edited Loading

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Jan 4, 2024

elupus left a comment

Choose a reason for hiding this comment

bdraco commented Jan 4, 2024

bdraco commented Jan 4, 2024 •

edited

Loading