Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix holiday HA language not supported #106554

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Dec 28, 2023

Proposed change

Package babel does not support all flavors of language so we default to English
Mainly an issue with English flavors such as en-GB

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @jrieger, mind taking a look at this pull request as it has been labeled with an integration (holiday) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of holiday can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign holiday Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

except UnknownLocaleError:
# Default to (US) English if language not recognized by babel
# Mainly an issue with English flavors such as "en-GB"
locale = Locale("en")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-holidays uses BCP 47 language tags, so it is en_GB there instead of en-GB. Maybe you could just replace the hyphen with an underscore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea but I'll keep the exception around anyhow

@bramkragten bramkragten merged commit b852eb7 into dev Dec 28, 2023
18 of 20 checks passed
@bramkragten bramkragten deleted the holiday-fix-language-not-supported branch December 28, 2023 15:10
@frenck
Copy link
Member

frenck commented Dec 28, 2023

@gjohansson-ST This one should not have been merged, as it is missing the required coverage on the configuration flow:

image

Can you add that as soon as possible?

@gjohansson-ST
Copy link
Member Author

@gjohansson-ST This one should not have been merged, as it is missing the required coverage on the configuration flow:

image

Can you add that as soon as possible?

@frenck should be fixed by #106559 but I'll make sure coverage is fixed in a follow-up if needed.

@gjohansson-ST
Copy link
Member Author

Coverage is 100% in dev

---------- coverage: platform linux, python 3.11.4-final-0 -----------
Name                                              Stmts   Miss  Cover   Missing
-------------------------------------------------------------------------------
homeassistant/components/holiday/__init__.py         10      0   100%
homeassistant/components/holiday/calendar.py         52      0   100%
homeassistant/components/holiday/config_flow.py      45      0   100%
homeassistant/components/holiday/const.py             3      0   100%
-------------------------------------------------------------------------------
TOTAL                                               110      0   100%

@frenck
Copy link
Member

frenck commented Dec 29, 2023

Thanks, @gjohansson-ST!
Awesome 👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holiday Integration - Unknown error occurred
4 participants