Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tessie honk button #106518

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Fix Tessie honk button #106518

merged 2 commits into from
Dec 28, 2023

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Dec 27, 2023

Proposed change

The honk button was missing lambda. Tests added to catch this mistake. Breakfix for beta 2024.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck changed the title Fix honk in Tessie (beta) Fix honk in Tessie Dec 28, 2023
@frenck
Copy link
Member

frenck commented Dec 28, 2023

@Bre77 Please don't add "(beta)" to the PR titles. Instead write in the PR description you for it to go into beta.

@frenck frenck added this to the 2024.1 milestone Dec 28, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bre77

@edenhaus edenhaus changed the title Fix honk in Tessie Fix Tessie honk button Dec 28, 2023
@edenhaus edenhaus merged commit 5b706ce into home-assistant:dev Dec 28, 2023
20 checks passed
bramkragten pushed a commit that referenced this pull request Dec 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants