-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct state for emulated_hue covers #106516
Conversation
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b1d984d
to
e4a559c
Compare
e4a559c
to
20a956a
Compare
IMO a closing cover should be considered "open" until it is fully closed. A closing garage door for example can still be entered while it is closing. The entity documentation is not entirely clear on how to handle this. @bdraco Any opinions? |
That makes sense to me |
20a956a
to
7f5c50d
Compare
7f5c50d
to
830905a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tho85
Proposed change
Expose closed covers as "off" via emulated_hue
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: