Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct state for emulated_hue covers #106516

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

Tho85
Copy link
Contributor

@Tho85 Tho85 commented Dec 27, 2023

Proposed change

Expose closed covers as "off" via emulated_hue

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (emulated_hue) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of emulated_hue can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign emulated_hue Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@ivanfmartinez
Copy link

I have tested this code and it solved the problem with alexa and blinds that I have reported on #106505

considering the suggestion of @bdraco of using _OFF_STATES dict I think that STATED_CLOSING should be used also to be converted to STATE_OFF

Thanks @Tho85

@Tho85 Tho85 force-pushed the Tho85/emulated-hue-state branch from e4a559c to 20a956a Compare December 28, 2023 11:44
@Tho85
Copy link
Contributor Author

Tho85 commented Dec 28, 2023

IMO a closing cover should be considered "open" until it is fully closed. A closing garage door for example can still be entered while it is closing. The entity documentation is not entirely clear on how to handle this.

@bdraco Any opinions?

@bdraco
Copy link
Member

bdraco commented Dec 28, 2023

IMO a closing cover should be considered "open" until it is fully closed.

That makes sense to me

@bdraco bdraco added this to the 2024.1 milestone Dec 28, 2023
@Tho85 Tho85 force-pushed the Tho85/emulated-hue-state branch from 20a956a to 7f5c50d Compare December 28, 2023 15:08
@MartinHjelmare MartinHjelmare changed the title emulated_hue: Use correct state for covers Use correct state for emulated_hue covers Dec 28, 2023
@Tho85 Tho85 force-pushed the Tho85/emulated-hue-state branch from 7f5c50d to 830905a Compare December 28, 2023 19:16
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tho85

@bdraco bdraco merged commit 6deb6dd into home-assistant:dev Dec 28, 2023
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulated Hue - does not respect open/closed state for cover/blind
4 participants