Add Binary Sensor platform to Tessie #105421

Bre77 · 2023-12-09T23:15:03Z

Breaking change

Proposed change

Add Binary Sensor platform to Tessie

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add binary sensor platform to Tessie home-assistant.io#30248

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

homeassistant/components/tessie/__init__.py

homeassistant/components/tessie/binary_sensor.py

homeassistant/components/tessie/entity.py

homeassistant/components/tessie/binary_sensor.py

homeassistant/components/tessie/strings.json

home-assistant · 2023-12-10T00:47:20Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Stale

bdraco

Please remove the unrelated commits from this PR

git checkout -b tessie-binary_squashed
git merge upstream/dev
git reset --soft upstream/dev
git commit -a -m'Add Binary Sensor platform to Tessie'

homeassistant/components/tessie/binary_sensor.py

Co-authored-by: J. Nick Koston <nick@koston.org>

homeassistant/components/tessie/coordinator.py

homeassistant/components/tessie/strings.json

tests/components/tessie/test_binary_sensors.py

Co-authored-by: J. Nick Koston <nick@koston.org>

homeassistant/components/tessie/sensor.py

bdraco · 2023-12-16T02:13:29Z

homeassistant/components/tessie/binary_sensor.py

+@dataclass
+class TessieBinarySensorEntityDescription(BinarySensorEntityDescription):


In a followup these should be changed due to a recent change https://developers.home-assistant.io/blog/2023/12/11/entity-description-changes/

This will come up a few times in the other platforms, but ill look at addressing them all once I fully understand the repercussions.

bdraco · 2023-12-16T02:14:41Z

Good to go once that last test is cleaned up

Bre77 · 2023-12-16T02:26:02Z

Tests passing.

comments were addresses in the other PR

homeassistant/components/tessie/strings.json

bdraco · 2023-12-16T04:22:01Z

I think there are still a few more or GitHub mobile is behind again

Co-authored-by: J. Nick Koston <nick@koston.org>

Bre77 · 2023-12-16T04:35:33Z

I think there are still a few more or GitHub mobile is behind again

Its not you, I made the changes on Github web on my mobile, so I missed some. Fixing the rest now.

MartinHjelmare · 2023-12-16T08:57:13Z

tests/components/tessie/test_binary_sensors.py

+
+from .common import TEST_VEHICLE_STATE_ONLINE, setup_platform
+
+OFFON = [STATE_OFF, STATE_ON]


OFFON isn't used.

Ah yes, that was an idea I gave up on. I'll raise a PR to remove it.

home-assistant bot added cla-signed has-tests integration: tessie new-feature new-integration by-code-owner Quality Scale: No score labels Dec 9, 2023

home-assistant bot previously requested changes Dec 9, 2023

View reviewed changes

Bre77 changed the title ~~Tessie binary~~ Add Binary Sensor platform to Tessie Dec 9, 2023

Bre77 mentioned this pull request Dec 9, 2023

Add binary sensor platform to Tessie home-assistant/home-assistant.io#30248

Merged

8 tasks

Bre77 marked this pull request as ready for review December 9, 2023 23:37

Bre77 marked this pull request as draft December 10, 2023 00:44

Bre77 marked this pull request as ready for review December 10, 2023 00:44

joostlek previously requested changes Dec 10, 2023

View reviewed changes

home-assistant bot marked this pull request as draft December 10, 2023 00:47

Bre77 force-pushed the tessie-binary branch from 48b7b88 to 861b998 Compare December 10, 2023 01:50

Bre77 marked this pull request as ready for review December 10, 2023 02:16

home-assistant bot requested a review from joostlek December 10, 2023 02:16

joostlek removed the new-integration label Dec 10, 2023

bdraco requested changes Dec 12, 2023

View reviewed changes

home-assistant bot marked this pull request as draft December 12, 2023 04:43

Add binary platform

bbc1234

Bre77 force-pushed the tessie-binary branch from cd151d3 to bbc1234 Compare December 12, 2023 05:01

Bre77 marked this pull request as ready for review December 12, 2023 05:05

home-assistant bot requested a review from bdraco December 12, 2023 05:05

bdraco reviewed Dec 12, 2023

View reviewed changes

homeassistant/components/tessie/binary_sensor.py Outdated Show resolved Hide resolved

Update homeassistant/components/tessie/binary_sensor.py

c5a917b

Co-authored-by: J. Nick Koston <nick@koston.org>

bdraco reviewed Dec 12, 2023

View reviewed changes

homeassistant/components/tessie/coordinator.py Outdated Show resolved Hide resolved

Bre77 added 2 commits December 15, 2023 22:36

Merge remote-tracking branch 'upstream/dev' into tessie-binary

15cbfcf

Other fixes

f7e1824

bdraco reviewed Dec 15, 2023

View reviewed changes

homeassistant/components/tessie/strings.json Outdated Show resolved Hide resolved

bdraco reviewed Dec 15, 2023

View reviewed changes

tests/components/tessie/test_binary_sensors.py Outdated Show resolved Hide resolved

Bre77 and others added 3 commits December 15, 2023 23:15

Use super native value

50561e3

Update tests/components/tessie/test_binary_sensors.py

0d2cdad

Co-authored-by: J. Nick Koston <nick@koston.org>

Remove unused issue

72e826a

bdraco reviewed Dec 15, 2023

View reviewed changes

homeassistant/components/tessie/sensor.py Outdated Show resolved Hide resolved

Bre77 and others added 5 commits December 15, 2023 23:39

remove unused bracket and ruff

4e51c1a

change to _value

5c6d7d4

Merge branch 'tessie-renames' into tessie-binary

2f520cd

Use _value

06fd0a9

Merge branch 'dev' into tessie-binary

a038f66

bdraco reviewed Dec 16, 2023

View reviewed changes

bdraco approved these changes Dec 16, 2023

View reviewed changes

Fix binary logic test

e35fcdf

bdraco approved these changes Dec 16, 2023

View reviewed changes

bdraco reviewed Dec 16, 2023

View reviewed changes

homeassistant/components/tessie/strings.json Outdated Show resolved Hide resolved

Tyre to tire

25ea811

Update homeassistant/components/tessie/strings.json

b8241da

Co-authored-by: J. Nick Koston <nick@koston.org>

Fix Tyres everywhere

d33bf27

bdraco approved these changes Dec 16, 2023

View reviewed changes

bdraco merged commit 887f9a2 into home-assistant:dev Dec 16, 2023
23 checks passed

MartinHjelmare reviewed Dec 16, 2023

View reviewed changes

github-actions bot locked and limited conversation to collaborators Dec 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Binary Sensor platform to Tessie #105421

Add Binary Sensor platform to Tessie #105421

Bre77 commented Dec 9, 2023 •

edited

Loading

home-assistant bot left a comment

home-assistant bot commented Dec 10, 2023

bdraco left a comment

bdraco Dec 16, 2023

Bre77 Dec 16, 2023

bdraco commented Dec 16, 2023

Bre77 commented Dec 16, 2023

bdraco commented Dec 16, 2023

Bre77 commented Dec 16, 2023

MartinHjelmare Dec 16, 2023

Bre77 Dec 16, 2023

		@dataclass
		class TessieBinarySensorEntityDescription(BinarySensorEntityDescription):


		from .common import TEST_VEHICLE_STATE_ONLINE, setup_platform

		OFFON = [STATE_OFF, STATE_ON]

Add Binary Sensor platform to Tessie #105421

Add Binary Sensor platform to Tessie #105421

Conversation

Bre77 commented Dec 9, 2023 • edited Loading

Breaking change

Proposed change

Type of change

Additional information

Checklist

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot commented Dec 10, 2023

bdraco left a comment

Choose a reason for hiding this comment

bdraco Dec 16, 2023

Choose a reason for hiding this comment

Bre77 Dec 16, 2023

Choose a reason for hiding this comment

bdraco commented Dec 16, 2023

Bre77 commented Dec 16, 2023

bdraco commented Dec 16, 2023

Bre77 commented Dec 16, 2023

MartinHjelmare Dec 16, 2023

Choose a reason for hiding this comment

Bre77 Dec 16, 2023

Choose a reason for hiding this comment

Bre77 commented Dec 9, 2023 •

edited

Loading