Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time entity to Renson #105031

Merged
merged 13 commits into from
Jan 6, 2024
Merged

Conversation

jimmyd-be
Copy link
Contributor

@jimmyd-be jimmyd-be commented Dec 4, 2023

Breaking change

The day_time and night_time sensor entities has been replaced by time entities.

Proposed change

Adding time entity to Renson integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

jimmyd-be/Renson-endura-delta-library@1.6.0...1.7.1

To help with the load of incoming pull requests:

@home-assistant home-assistant bot marked this pull request as draft December 5, 2023 15:04
@home-assistant
Copy link

home-assistant bot commented Dec 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jimmyd-be jimmyd-be marked this pull request as ready for review December 5, 2023 19:31
@home-assistant home-assistant bot requested a review from jpbede December 5, 2023 19:31
@jimmyd-be jimmyd-be force-pushed the rensone_time_entities branch from 52b5d6e to 05d708b Compare December 6, 2023 18:31
@home-assistant home-assistant bot marked this pull request as draft December 7, 2023 09:02
@jimmyd-be jimmyd-be marked this pull request as ready for review December 10, 2023 13:13
@home-assistant home-assistant bot requested a review from edenhaus December 10, 2023 13:13
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the breaking change section of the description as you convert sensor entities to time entities, which is considered as breaking change

@home-assistant home-assistant bot marked this pull request as draft December 18, 2023 08:41
@jimmyd-be jimmyd-be marked this pull request as ready for review December 21, 2023 16:51
@home-assistant home-assistant bot requested a review from edenhaus December 21, 2023 16:51
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure CI is passing. Currently there are some lint errors

@home-assistant home-assistant bot marked this pull request as draft December 28, 2023 12:42
@jimmyd-be jimmyd-be marked this pull request as ready for review December 28, 2023 13:15
@home-assistant home-assistant bot requested a review from edenhaus December 28, 2023 13:15
@home-assistant home-assistant bot marked this pull request as draft December 30, 2023 10:22
@jimmyd-be jimmyd-be force-pushed the rensone_time_entities branch from e13e8ad to 9c152f3 Compare January 5, 2024 11:54
@jimmyd-be jimmyd-be marked this pull request as ready for review January 5, 2024 12:11
@home-assistant home-assistant bot requested a review from jpbede January 5, 2024 12:11
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, than this is good to go 👍

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jimmyd-be 👍

@jpbede jpbede dismissed edenhaus’s stale review January 6, 2024 08:26

Comments addressed

@jpbede jpbede merged commit ee67c97 into home-assistant:dev Jan 6, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants