-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time entity to Renson #105031
Add time entity to Renson #105031
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
52b5d6e
to
05d708b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out the breaking change section of the description as you convert sensor entities to time entities, which is considered as breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure CI is passing. Currently there are some lint errors
e13e8ad
to
9c152f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing, than this is good to go 👍
Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @jimmyd-be 👍
Breaking change
The
day_time
andnight_time
sensor entities has been replaced by time entities.Proposed change
Adding time entity to Renson integration
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.jimmyd-be/Renson-endura-delta-library@1.6.0...1.7.1
To help with the load of incoming pull requests: