Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sensors for Shelly Pro Dimmer 2PM #105008

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Add missing sensors for Shelly Pro Dimmer 2PM #105008

merged 1 commit into from
Dec 25, 2023

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Dec 4, 2023

Breaking change

Proposed change

Shelly Pro Dimmer 2PM is the first model which provide energy measurement sensors for the light platform. This PR adds missing sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2023

Hey there @balloob, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@chemelli74
Copy link
Contributor

Cannot test right now ( Tomorrow I should get mine ), but looks good.

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR itself looks good, however I noticed a strange value for the energy so I moved a bulb to the 2nd channel at let it run constantly at 20.8W for exactly 1 hour.
"aenergy":{"total":179.014,"by_minute":[1999.420,3018.680,3004.520],"minute_ts":1701893203}
image

The value looks about 8.6 times larger than expected, I think it is a Shelly FW bug, but would be good to wait until we get feedback about it from Shelly

@bieniu
Copy link
Member Author

bieniu commented Dec 10, 2023

@thecode There was a similar problem previously related to Plus PM, the pre-sale devices were not properly calibrated.
Have you asked Shelly team about this?

@thecode
Copy link
Member

thecode commented Dec 10, 2023

@thecode There was a similar problem previously related to Plus PM, the pre-sale devices were not properly calibrated. Have you asked Shelly team about this?

I did, device is calibrated correctly since it shows the correct power, energy is calculated from the power so either it uses different units or a bug in the device FW.

@bieniu
Copy link
Member Author

bieniu commented Dec 10, 2023

So we have to ask about the unit.

@home-assistant home-assistant deleted a comment from bieniu Dec 12, 2023
@thecode
Copy link
Member

thecode commented Dec 12, 2023

@bieniu make sure not to expose private URLs, the link was to a private repo.
As for the energy sensor I think we can wait two weeks and if it is not resolved/root cause identified merge this PR before beta.

@bieniu
Copy link
Member Author

bieniu commented Dec 12, 2023

Ops sorry, my bad.

@bieniu bieniu changed the title Add missing sensors for Shelly Pro Dimmer 2 Add missing sensors for Shelly Pro Dimmer 2PM Dec 23, 2023
@bieniu
Copy link
Member Author

bieniu commented Dec 23, 2023

New firmware for the device is not available and I doubt it will be available before the beta cut. Do we want to hold off with this PR until the 2024.2 release? I think it might be part of 2024.1.

@chemelli74
Copy link
Contributor

I think we can merge it as I think the firmware will be out the first days of Jan.

@bieniu bieniu merged commit d59142a into home-assistant:dev Dec 25, 2023
20 checks passed
@bieniu bieniu deleted the shelly-pro-dimmer-2 branch December 25, 2023 06:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants