-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing sensors for Shelly Pro Dimmer 2PM #105008
Conversation
Hey there @balloob, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Cannot test right now ( Tomorrow I should get mine ), but looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR itself looks good, however I noticed a strange value for the energy so I moved a bulb to the 2nd channel at let it run constantly at 20.8W for exactly 1 hour.
"aenergy":{"total":179.014,"by_minute":[1999.420,3018.680,3004.520],"minute_ts":1701893203}
The value looks about 8.6 times larger than expected, I think it is a Shelly FW bug, but would be good to wait until we get feedback about it from Shelly
@thecode There was a similar problem previously related to Plus PM, the pre-sale devices were not properly calibrated. |
I did, device is calibrated correctly since it shows the correct power, energy is calculated from the power so either it uses different units or a bug in the device FW. |
So we have to ask about the unit. |
@bieniu make sure not to expose private URLs, the link was to a private repo. |
Ops sorry, my bad. |
New firmware for the device is not available and I doubt it will be available before the beta cut. Do we want to hold off with this PR until the 2024.2 release? I think it might be part of 2024.1. |
I think we can merge it as I think the firmware will be out the first days of Jan. |
Breaking change
Proposed change
Shelly Pro Dimmer 2PM is the first model which provide energy measurement sensors for the light platform. This PR adds missing sensors.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: