Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config flow to Suez water #104730

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Add config flow to Suez water #104730

merged 14 commits into from
Dec 11, 2023

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Nov 29, 2023 •
edited
Loading

Breaking change

The Suez water YAML configuration is deprecated. Your old configuration will be imported.

Proposed change

Add config flow to Suez water

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: suez_water new-feature Quality Scale: No score labels Nov 29, 2023
@home-assistant
Copy link

Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek marked this pull request as ready for review December 2, 2023 11:31
gjohansson-ST
gjohansson-ST requested changes Dec 4, 2023
View reviewed changes
homeassistant/components/suez_water/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 4, 2023 16:05
@home-assistant
Copy link

home-assistant bot commented Dec 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek marked this pull request as ready for review December 4, 2023 16:13
gjohansson-ST
gjohansson-ST approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joostlek 👍

@gjohansson-ST gjohansson-ST merged commit a187a39 into home-assistant:dev Dec 11, 2023
53 checks passed
@joostlek joostlek deleted the suez_cf branch December 11, 2023 21:26
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 12, 2023
@joostlek @Bre77
Add config flow to Suez water (home-assistant#104730)
ca7de68 
* Add config flow to Suez water

* fix tests

* Complete coverage

* Change version to 2024.7

* Fix final test

* Add issue when import is successful

* Move hassdata

* Do unique_id

* Remove import issue when entry already exists

* Remove import issue when entry already exists
@frenck
Copy link
Member

frenck commented Dec 12, 2023 •
edited
Loading

Seems like this PR is missing a documentation PR and should thus not have been merged.

Can you open up a documentation PR @joostlek?

/CC @gjohansson-ST

@gjohansson-ST
Copy link
Member

Yes. Told @joostlek yesterday on discord yesterday when I noticed. He will make one.

@joostlek joostlek mentioned this pull request Dec 12, 2023
Merged
8 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@gjohansson-ST gjohansson-ST gjohansson-ST approved these changes

Assignees
No one assigned
Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: suez_water new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joostlek @frenck @gjohansson-ST @MartinHjelmare