Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bimmer-connected to 0.14.5 #104715

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented Nov 29, 2023

Proposed change

Bump bimmer-connected to 0.14.5. If there still is a bugfix release before 2023.12, including this would be great.

0.14.5 fixes an error where reauthentication flows were triggered although this was not required. This only happened after a 429 Too Many Requests error which for some reason have started coming up this week.

0.14.4 adds a [china] extra so we do not require Pillow by default. We have multiple users still using Raspbian 32bit where no wheels are available and compiling proves to be difficult.

Diff: bimmerconnected/bimmer_connected@0.14.3...0.14.5
Release notes:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bmw_connected_drive can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bmw_connected_drive Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

frenck
frenck previously requested changes Nov 29, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, can you take a look? 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 29, 2023 14:20
@rikroe
Copy link
Contributor Author

rikroe commented Nov 29, 2023

Thanks - forgot that removing an attribute in the lib also changes the diagnostics snapshot.

@rikroe rikroe marked this pull request as ready for review November 29, 2023 14:44
@home-assistant home-assistant bot requested a review from frenck November 29, 2023 14:44
@rikroe
Copy link
Contributor Author

rikroe commented Nov 29, 2023

Unrelated test failed in CI:
FAILED tests/util/test_executor.py::test_overall_timeout_reached

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rikroe 👍

@edenhaus edenhaus merged commit 2287c45 into home-assistant:dev Nov 29, 2023
45 of 46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@joostlek joostlek modified the milestone: 2023.12.0 Dec 1, 2023
@frenck frenck removed this from the 2023.12.0 milestone Dec 4, 2023
@frenck
Copy link
Member

frenck commented Dec 4, 2023

Not sure why this one was marked for the milestone, as it was already part of the initial beta cut.

See:
CleanShot 2023-12-04 at 14 56 54@2x

Removed the milestone from this PR.

@rikroe rikroe deleted the bumw-dependency branch December 21, 2023 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants