-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show site state in Amberelectric config flow #104702
Show site state in Amberelectric config flow #104702
Conversation
Add support for price descriptors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Currently your library repo has the latest release is 1.0.4
and there exists also no tag/information for 1.1.0
Thanks already! 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
be8da49
to
250ecc8
Compare
…ociated closed site
250ecc8
to
113cd78
Compare
@edenhaus the coverage failure is due to a 404. Can you please rerun it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry forgot to publish my review :)
…me-assistant into amberelectric-fix-rejoin-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @madpilot 👍
|
Proposed change
Allows customers that have left, and come back to Amber to select the correct site. Fixes: #97309
To facilitate change, bumped
amberelectric
version to1.1.0
which adds the site status. Changelog: https://github.com/madpilot/amberelectric.py/releases/tag/v1.1.0 (Diff: https://github.com/madpilot/amberelectric.py/pull/9/files)Screenshot of change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: