Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show site state in Amberelectric config flow #104702

Merged
merged 24 commits into from
Feb 5, 2024

Conversation

madpilot
Copy link
Contributor

@madpilot madpilot commented Nov 29, 2023

Proposed change

Allows customers that have left, and come back to Amber to select the correct site. Fixes: #97309

To facilitate change, bumped amberelectric version to 1.1.0 which adds the site status. Changelog: https://github.com/madpilot/amberelectric.py/releases/tag/v1.1.0 (Diff: https://github.com/madpilot/amberelectric.py/pull/9/files)

Screenshot of change

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@madpilot madpilot changed the title Amberelectric fix rejoin bug Amberelectric integration: Allow customers that have left, and re-joined Amber to select the correct site Nov 29, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 30, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Currently your library repo has the latest release is 1.0.4 and there exists also no tag/information for 1.1.0

Thanks already! 👍

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 30, 2023 08:42
@madpilot madpilot marked this pull request as ready for review November 30, 2023 09:28
@home-assistant home-assistant bot requested a review from edenhaus November 30, 2023 09:28
@home-assistant home-assistant bot marked this pull request as draft November 30, 2023 10:25
@frenck frenck marked this pull request as ready for review November 30, 2023 17:10
@madpilot madpilot force-pushed the amberelectric-fix-rejoin-bug branch from be8da49 to 250ecc8 Compare January 11, 2024 05:57
@madpilot madpilot force-pushed the amberelectric-fix-rejoin-bug branch from 250ecc8 to 113cd78 Compare January 11, 2024 06:01
@home-assistant home-assistant bot marked this pull request as draft January 11, 2024 09:27
@madpilot madpilot requested a review from edenhaus January 12, 2024 04:04
@madpilot
Copy link
Contributor Author

@edenhaus the coverage failure is due to a 404. Can you please rerun it?

@madpilot madpilot marked this pull request as ready for review January 15, 2024 09:14
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to publish my review :)

homeassistant/components/amberelectric/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/amberelectric/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/amberelectric/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/amberelectric/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/amberelectric/config_flow.py Outdated Show resolved Hide resolved
tests/components/amberelectric/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/amberelectric/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/amberelectric/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/amberelectric/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft February 1, 2024 16:29
@madpilot madpilot marked this pull request as ready for review February 5, 2024 08:46
@home-assistant home-assistant bot requested a review from edenhaus February 5, 2024 08:46
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madpilot 👍

@edenhaus
Copy link
Contributor

edenhaus commented Feb 5, 2024

CI / Run tests Python 3.12 (8) (pull_request) unrelated

@edenhaus edenhaus changed the title Allow Amberelectric customers that have left and re-joined Amber to select correct site Show site state in Amberelectric config flow Feb 5, 2024
@edenhaus edenhaus merged commit 41a256a into home-assistant:dev Feb 5, 2024
48 of 49 checks passed
@edenhaus edenhaus added this to the 2024.2.0 milestone Feb 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amberelectric integration - not handling inactive sites
4 participants