Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fan and reduce I/O calls in radiotherm #10437

Merged
merged 9 commits into from
Nov 22, 2017
Merged

Add fan and reduce I/O calls in radiotherm #10437

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6e63db2
Added fan support. Reduced number of calls to the thermostat to a mi…
TD22057 Nov 7, 2017
8a5dc84
Move temp rounding to config schema
TD22057 Nov 10, 2017
b2ce9ec
Fixed pep8 errors
TD22057 Nov 10, 2017
ed1662d
Fix for review comments.
TD22057 Nov 14, 2017
33136e6
removed unneeded if block
TD22057 Nov 14, 2017
63cf64d
Added missing precision attr back
TD22057 Nov 14, 2017
de626ee
Fixed pylint errors
TD22057 Nov 20, 2017
59c79bc
Code review fixes. Fan support by model number.
TD22057 Nov 22, 2017
5018641
Defined circulate state
TD22057 Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed unneeded if block
  • Loading branch information
@TD22057
TD22057 committed Nov 14, 2017
commit 33136e639be8365a2a8a84affbe7926c541d1a22
4 changes: 1 addition & 3 deletions homeassistant/components/climate/radiotherm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,7 @@ def set_time(self):

def set_operation_mode(self, operation_mode):
"""Set operation mode (auto, cool, heat, off)."""
if operation_mode == STATE_OFF:
self.device.tmode = TEMP_MODE_TO_CODE[operation_mode]
elif operation_mode == STATE_AUTO:
if operation_mode == STATE_OFF or operation_mode == STATE_AUTO:
self.device.tmode = TEMP_MODE_TO_CODE[operation_mode]

# Setting t_cool or t_heat automatically changes tmode.
Expand Down