-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ZHA dependencies #104335
Bump ZHA dependencies #104335
Conversation
Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
d084d7c
to
0c9d820
Compare
From the breaking changes:
Regarding the above, I do wonder if this will (negatively) affect instances with LAN/WiFi coordinators, as a small outage can sometimes be caused if a switch/AP/router is updated or if the LAN isn't ready/up when Home Assistant first starts. Other integrations (like ESPHome) continuously try to reconnect in the background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my above comment, the actual changes LGTM.
Also did some quick tests and everything seems to work as expected.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Transient connection errors always result in a |
Ah, yeah. Should have looked closer. For other people reading the breaking changes, maybe mention that network coordinators aren't affected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
17acef5
to
d2833c7
Compare
Rebased to resolve a merge conflict after merging #104683 |
Breaking change
ZHA will no longer auto-reconnect to your USB coordinator if it is unplugged. Connections to network coordinators will still be retried, however. You will need to reload the integration to reconnect.
Proposed change
Bump all ZHA dependencies:
This is a small rearchitecture of zigpy:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: