Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zwave_js device on device reset #104291

Merged
merged 5 commits into from
Dec 9, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Nov 21, 2023

Proposed change

Per zwave-js/certification-backlog#6 (comment) we must remove the device when the device is reset.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@AlCalzone
Copy link
Contributor

No need to reload the integration. Just make sure the device gets removed as the result of the node removed event.

@raman325 raman325 changed the title Reload zwave_js config entry on device reset Remove zwave_js device on device reset Nov 21, 2023
@raman325 raman325 marked this pull request as ready for review November 21, 2023 17:24
@raman325 raman325 requested a review from a team as a code owner November 21, 2023 17:24
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 23, 2023
@home-assistant home-assistant bot marked this pull request as draft November 23, 2023 11:21
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 24, 2023
@raman325 raman325 marked this pull request as ready for review December 6, 2023 11:04
@MartinHjelmare MartinHjelmare marked this pull request as draft December 6, 2023 11:12
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raman325 raman325 marked this pull request as ready for review December 9, 2023 16:43
@MartinHjelmare MartinHjelmare merged commit 4e1677e into home-assistant:dev Dec 9, 2023
23 checks passed
@raman325 raman325 deleted the reload branch December 10, 2023 00:19
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 10, 2023
* Reload zwave_js config entry on device reset

* remove device

* Just remove the device and don't reload

* revert change to notification message

* Assert device is no longer there
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify user about factory reset of end devices
4 participants