Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of package errors #103976

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Nov 14, 2023

Proposed change

Improve formatting of package errors

In particular, the error message when a package refers to a non-existing integration is improved:

Package pack_5 setup failed. Integration 'unknown_integration' not found. (See configuration.yaml:23).

Compared to before:

Package pack_5 setup failed. Integration unknown_integration Integration 'unknown_integration' not found. (See configuration.yaml:23).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

There's a merge conflict.

@emontnemery emontnemery force-pushed the package_errors_improve_formatting branch from aa970cf to af6c7f5 Compare November 16, 2023 07:35
@MartinHjelmare MartinHjelmare merged commit 98030a9 into dev Nov 16, 2023
@MartinHjelmare MartinHjelmare deleted the package_errors_improve_formatting branch November 16, 2023 08:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants