Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dominos Pizza platform #10379

Merged
merged 37 commits into from
Nov 24, 2017
Merged

Add Dominos Pizza platform #10379

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
3bca66e
add dominos service
craigjmidwinter Oct 20, 2017
b4c34c2
change require
craigjmidwinter Oct 26, 2017
6a3813b
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
craigjmidwinter Oct 30, 2017
4faf97d
dump to log
craigjmidwinter Nov 3, 2017
64adc01
component fixes
craigjmidwinter Nov 4, 2017
27d63a9
clean-up use updated library
craigjmidwinter Nov 4, 2017
b536647
remove unnecessary import
craigjmidwinter Nov 4, 2017
18bbbca
fix hound errors
craigjmidwinter Nov 5, 2017
2793808
more lint fixes
craigjmidwinter Nov 5, 2017
a1ba981
Coverage rc
craigjmidwinter Nov 5, 2017
2b9749f
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
craigjmidwinter Nov 5, 2017
456a1c4
update requirements
craigjmidwinter Nov 5, 2017
fe574e6
cleanup as per notes
craigjmidwinter Nov 7, 2017
03ad3ac
missing message
craigjmidwinter Nov 7, 2017
646cebc
linting...
craigjmidwinter Nov 7, 2017
c5f70d2
schema validation and reducing requests
craigjmidwinter Nov 7, 2017
fd90800
Merge branch 'dev' of https://github.com/home-assistant/home-assistan…
craigjmidwinter Nov 7, 2017
c59fe34
fixlint
craigjmidwinter Nov 7, 2017
bd1f914
spacing
craigjmidwinter Nov 7, 2017
7838ceb
unused variable
craigjmidwinter Nov 7, 2017
f0d70ae
fix docstrings
craigjmidwinter Nov 7, 2017
a6c0ca6
update req
craigjmidwinter Nov 8, 2017
cffcd13
notes updates, pypi package, front-end panel
craigjmidwinter Nov 12, 2017
53f4acc
stale import
craigjmidwinter Nov 12, 2017
33e6062
fix constant name
craigjmidwinter Nov 12, 2017
db75ffb
docstrings
craigjmidwinter Nov 12, 2017
ca1a115
fix library import
craigjmidwinter Nov 12, 2017
28542ae
lint fixes
craigjmidwinter Nov 12, 2017
3172f43
pylint bug
craigjmidwinter Nov 12, 2017
fc9808d
remove built-in panel
craigjmidwinter Nov 15, 2017
810a248
Make synchronous
craigjmidwinter Nov 16, 2017
6c049cb
unused import and use throttle
craigjmidwinter Nov 16, 2017
b9815f1
Handle exceptions properly and update client
craigjmidwinter Nov 16, 2017
483934d
Import exceptions properly
craigjmidwinter Nov 16, 2017
81f7d10
unused import
craigjmidwinter Nov 16, 2017
0c1c81e
remove bloat from start-up, readability fixes from notes, retrieve me…
craigjmidwinter Nov 24, 2017
c91b719
whitespace on blank line
craigjmidwinter Nov 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix constant name
  • Loading branch information
@craigjmidwinter
craigjmidwinter committed Nov 12, 2017
commit 33e6062a2085400ee2e85cd4c7574f81a147065a
2 changes: 1 addition & 1 deletion homeassistant/components/dominos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def async_setup(hass, config):

hass.services.async_register(DOMAIN, 'order', dominos.handle_order)

if config[DOMAIN].get(ATTR_DUMP_MENU):
if config[DOMAIN].get(ATTR_SHOW_MENU):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You keep doing config[DOMAIN] everywhere. May I suggest a conf = config[DOMAIN] at the top

yield from dominos.dump_menu(hass)
hass.http.register_view(DominosProductListView)
yield from hass.components.frontend.async_register_built_in_panel(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've closed the PR for the built-in panel. This is too much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to build it out to a food component with platforms that offer a menu and allow ordering, a panel would be ok.

Expand Down