Use decorator for AsusWrt api calls #103690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kennedyshead, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
ollo69
force-pushed
the
asuswrt-use-decorator
branch
from
280f965 to
ad2851a
Compare
edenhaus
requested changes
Nov 10, 2023
| @@ -52,6 +54,28 @@ def _get_dict(keys: list, values: list) -> dict[str, Any]: | |||
| return dict(zip(keys, values)) | |||
|
|
|||
|
|
|||
| def handle_errors_and_zip(exceptions: Any, keys: list | None) -> Callable: | |||
There was a problem hiding this comment.
Can you please improve the typing by setting the arguments and return value of the callable
There was a problem hiding this comment.
Improved. Let me know if it looks good.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
edenhaus
requested changes
Nov 10, 2023
| """Create a dict from a list of keys and values.""" | ||
| return dict(zip(keys, values)) | ||
| def handle_errors_and_zip( | ||
| exceptions: Union[type[Exception], tuple[type[Exception], ...]], |
There was a problem hiding this comment.
Suggested change
| exceptions: Union[type[Exception], tuple[type[Exception], ...]], | |
| exceptions: type[Exception] | tuple[type[Exception], ...], |
There was a problem hiding this comment.
I improved a little bit more typing defining 2 type alias,
edenhaus
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use a decorator to avoid repetition of same code in the API calls inside
bridge.pymodule.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: