Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2C Trydan EVSE integration #103478

Merged
merged 15 commits into from
Nov 7, 2023

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Nov 6, 2023

Proposed change

This is an initial PR supporting a single sensor (follow up PR's will add more sensors, switches, etc)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 09:20
@home-assistant
Copy link

home-assistant bot commented Nov 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dgomes dgomes marked this pull request as ready for review November 6, 2023 21:31
@home-assistant home-assistant bot requested a review from joostlek November 6, 2023 21:31
@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 21:37
dgomes and others added 4 commits November 6, 2023 21:46
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@dgomes dgomes marked this pull request as ready for review November 6, 2023 23:27
@home-assistant home-assistant bot requested a review from joostlek November 6, 2023 23:27
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 23:41
@dgomes dgomes marked this pull request as ready for review November 7, 2023 08:56
@home-assistant home-assistant bot requested a review from joostlek November 7, 2023 08:56
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config flow coverage should be 100%

@home-assistant home-assistant bot marked this pull request as draft November 7, 2023 09:02
@dgomes dgomes mentioned this pull request Nov 7, 2023
11 tasks
@dgomes dgomes marked this pull request as ready for review November 7, 2023 20:52
@home-assistant home-assistant bot requested a review from joostlek November 7, 2023 20:52
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joostlek joostlek merged commit 0d67557 into home-assistant:dev Nov 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments in a new PR. Thanks!

@home-assistant home-assistant unlocked this conversation Nov 10, 2023
dgomes added a commit to dgomes/home-assistant that referenced this pull request Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants