-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vallox_websocket_api to 4.0.2 #103339
Conversation
Hey there @andre-richter, @viiru-, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@yozik04 it looks like the UUID of the Vallox unit changes with the update 🤔 This means that a new device and entities are added and all the old entities are made unavailable after the upgrade, which is a bit annoying. In my dev instance my Vallox unit got UUID |
It can be that previous was just wrong :) can you validate it somehow? |
What does this return for you on 3.3.0 vs 4.0.0? import asyncio
from vallox_websocket_api import Vallox
client = Vallox('ip.address')
async def run():
info = await client.get_info()
print(f"client.get_info(): {info}")
asyncio.new_event_loop().run_until_complete(run()) With 3.3.0:
With 4.0.0:
|
Ah, the Vallox web UI actually lists it too. It says the same as on version 3.3.0 of |
Reproduced. Will investigate. |
Fixed in 4.0.2 |
Thank you, confirmed in HA that upgrading does not add a second device now and that the Need to dig into the test failures now then.. 🤔 |
Proposed change
Changelog: yozik04/vallox_websocket_api@3.3.0...4.0.2
Attempts to fix #99294.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: