Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vallox_websocket_api to 4.0.2 #103339

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

slovdahl
Copy link
Contributor

@slovdahl slovdahl commented Nov 3, 2023

Proposed change

Changelog: yozik04/vallox_websocket_api@3.3.0...4.0.2

Attempts to fix #99294.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 3, 2023

Hey there @andre-richter, @viiru-, mind taking a look at this pull request as it has been labeled with an integration (vallox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vallox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vallox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@slovdahl
Copy link
Contributor Author

slovdahl commented Nov 3, 2023

@yozik04 it looks like the UUID of the Vallox unit changes with the update 🤔 This means that a new device and entities are added and all the old entities are made unavailable after the upgrade, which is a bit annoying.

In my dev instance my Vallox unit got UUID 83f56834-6639-41c0-b727-b896b7633bbd before, and now 83f56834-6639-41c0-b727-b896b7630024. So only the last 4 characters have changed, 3bbd -> 0024. Any idea what could cause it?

@yozik04
Copy link
Contributor

yozik04 commented Nov 3, 2023

It can be that previous was just wrong :) can you validate it somehow?

@slovdahl
Copy link
Contributor Author

slovdahl commented Nov 3, 2023

What does this return for you on 3.3.0 vs 4.0.0?

import asyncio
from vallox_websocket_api import Vallox

client = Vallox('ip.address')

async def run():
    info = await client.get_info()
    print(f"client.get_info(): {info}")

asyncio.new_event_loop().run_until_complete(run())

With 3.3.0:

$ python test.py 
client.get_info(): {'model': 'Vallox 110 MV', 'sw_version': '2.0.2', 'uuid': UUID('83f56834-6639-41c0-b727-b896b7633bbd')}

With 4.0.0:

$ python test.py 
client.get_info(): {'model': 'Vallox 110 MV', 'sw_version': '2.0.2', 'uuid': UUID('83f56834-6639-41c0-b727-b896b7630024')}

@slovdahl
Copy link
Contributor Author

slovdahl commented Nov 3, 2023

Ah, the Vallox web UI actually lists it too. It says the same as on version 3.3.0 of vallox_websocket_api.

@yozik04
Copy link
Contributor

yozik04 commented Nov 4, 2023

Reproduced. Will investigate.

@yozik04
Copy link
Contributor

yozik04 commented Nov 4, 2023

Fixed in 4.0.2

@slovdahl slovdahl changed the title Bump vallox_websocket_api to 4.0.0 Bump vallox_websocket_api to 4.0.2 Nov 4, 2023
@slovdahl
Copy link
Contributor Author

slovdahl commented Nov 4, 2023

Fixed in 4.0.2

Thank you, confirmed in HA that upgrading does not add a second device now and that the test.py script gives the same UUID 👍🙇

Need to dig into the test failures now then.. 🤔

@slovdahl slovdahl mentioned this pull request Nov 4, 2023
@slovdahl slovdahl marked this pull request as ready for review November 4, 2023 17:30
@bdraco bdraco merged commit c04db6a into home-assistant:dev Nov 4, 2023
@bdraco
Copy link
Member

bdraco commented Nov 4, 2023

Thanks @slovdahl @yozik04

@slovdahl slovdahl deleted the vallox-version-bump branch November 4, 2023 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vallox data handling
3 participants