Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB send retry after IOError #10263

Merged
merged 17 commits into from
Nov 24, 2017
Merged

InfluxDB send retry after IOError #10263

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8e3ad10
Implement data write retry for InfluxDB
janLo Apr 23, 2017
a37a249
Add unittest for influx write retries
janLo Apr 23, 2017
5ca3151
Add RetryOnError as helper decorator in util
janLo Apr 27, 2017
b05d452
Add unittests for RetryOnError
janLo Apr 27, 2017
514a3ac
Use RetryOnError decorator in InfluxDB
janLo Apr 27, 2017
570eaaa
Make the linters happy
janLo Apr 27, 2017
b7088ac
Implement a queue limit for the retry decorator.
janLo Oct 31, 2017
5794d94
influxdb: Add the retry queue limit option.
janLo Oct 31, 2017
eeeaf64
Make the linter happy.
janLo Oct 31, 2017
3810cf4
Make pylint happy
janLo Nov 1, 2017
1546ceb
Log exception of dropped retry
janLo Nov 22, 2017
18204e7
Move RetryOnError decorator to influxdb component.
janLo Nov 22, 2017
bdbf9d0
Fix bug in logging usage
janLo Nov 22, 2017
2cb43ed
Fix imports
janLo Nov 22, 2017
9ab35ee
Add newlines at the end of files.
janLo Nov 22, 2017
7fd1252
Remove blank line
balloob Nov 24, 2017
9ac1a53
Remove blank line
balloob Nov 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Log exception of dropped retry
  • Loading branch information
@janLo
janLo committed Nov 22, 2017
commit 1546cebb05a24d95d9b2537f51426671aaad574c
7 changes: 6 additions & 1 deletion homeassistant/util/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,14 +362,18 @@ def scheduled(retry=0, untrack=None, event=None):
# pylint: disable=broad-except
try:
method(*args, **kwargs)
except Exception:
except Exception as ex:
if retry == self.retry_limit:
raise
if len(wrapper._retry_queue) >= self.queue_limit:
last = wrapper._retry_queue.pop(0)
if 'remove' in last:
func = last['remove']
func()
if 'exc' in last:
_LOGGER.error(
"Retry queue overflow, drop oldest entry",
last['exc'])

target = utcnow() + self.retry_delay
tracking = {'target': target}
Expand All @@ -379,6 +383,7 @@ def scheduled(retry=0, untrack=None, event=None):
tracking),
target)
tracking['remove'] = remove
tracking["exc"] = ex
wrapper._retry_queue.append(tracking)

scheduled()
Expand Down