Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the safe_mode integration to recovery_mode #102581

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 23, 2023

Proposed change

Rename the safe_mode integration to recovery_mode

Background in #102580

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (safe_mode) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of safe_mode can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign safe_mode Removes the current integration label and assignees on the pull request, add the integration domain after the command.

"codeowners": ["@home-assistant/core"],
"config_flow": false,
"dependencies": ["frontend", "persistent_notification", "cloud"],
"documentation": "https://www.home-assistant.io/integrations/safe_mode",
"documentation": "https://www.home-assistant.io/integrations/recovery_mode",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the docs PR, where you rename the integration in the docs

@home-assistant home-assistant bot marked this pull request as draft October 23, 2023 09:52
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@emontnemery emontnemery marked this pull request as ready for review October 24, 2023 07:10
@home-assistant home-assistant bot requested a review from edenhaus October 24, 2023 07:10
@emontnemery emontnemery dismissed edenhaus’s stale review October 24, 2023 07:10

Documentation link has been added

@emontnemery emontnemery merged commit b953f29 into dev Oct 24, 2023
@emontnemery emontnemery deleted the rename_safe_mode_integration branch October 24, 2023 07:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants