Validate steps in Flowhandler #102152
Merged
Validate steps in Flowhandler #102152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
Hacktoberfest
small-pr
MartinHjelmare
approved these changes
Oct 17, 2023
MartinHjelmare
approved these changes
Oct 17, 2023
| @@ -77,7 +77,10 @@ async def test_invalid_credentials(hass: HomeAssistant) -> None: | |||
| ), | |||
| ), patch( | |||
| "homeassistant.components.abode.config_flow.AbodeFlowHandler.async_step_reauth", | |||
There was a problem hiding this comment.
We shouldn't patch this. Better to let it create a flow and check that there's a flow in progress with reauth source.
There was a problem hiding this comment.
I agree, but this is not the PR where that should be fixed
There was a problem hiding this comment.
Yes, it was just a side note.
elupus
reviewed
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Validate steps in Flowhandler
Integrations failing tests because of this will be fixed in separate PRs
Needs:
TODO: Add tests
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: