-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code owner from withings #102081
Remove code owner from withings #102081
Conversation
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robbie, I want to talk you a lot for all work you have done previously on Withings. Sorry for all the mails about PRs in the recent weeks, I think the integration turned into something beautiful and extendable and it all started because you made the integration.
❤️ Thanks for your efforts.
@joostlek I'm pleased somebody is taking interest in this integration and welcome additional questions about this integration or anything else. In reality, I don't have any more Withings device to test against. So I can't really to this integration justice. |
I think I got the integration in a place where its working great. Going to add more features in the following days probably. One thing I did want to ask, was there a reason we aggregated sleep data since 12am the day before instead of just picking the last day? When I check the test data I get from Withings, it looks like I get 1 sleep session per day. I got an issue reported for this and made a proposal for it (which I am having some people test, since I don't have the sleeping mat). But I couldn't really figure out a reason. |
Proposed change
Remove codeowner (self) from withings integration.
Type of change
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: