Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code owner from withings #102081

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Remove code owner from withings #102081

merged 2 commits into from
Oct 15, 2023

Conversation

vangorra
Copy link
Contributor

Proposed change

Remove codeowner (self) from withings integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (withings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of withings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign withings Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robbie, I want to talk you a lot for all work you have done previously on Withings. Sorry for all the mails about PRs in the recent weeks, I think the integration turned into something beautiful and extendable and it all started because you made the integration.

❤️ Thanks for your efforts.

@vangorra
Copy link
Contributor Author

@joostlek I'm pleased somebody is taking interest in this integration and welcome additional questions about this integration or anything else. In reality, I don't have any more Withings device to test against. So I can't really to this integration justice.

@joostlek
Copy link
Member

I think I got the integration in a place where its working great. Going to add more features in the following days probably.

One thing I did want to ask, was there a reason we aggregated sleep data since 12am the day before instead of just picking the last day? When I check the test data I get from Withings, it looks like I get 1 sleep session per day. I got an issue reported for this and made a proposal for it (which I am having some people test, since I don't have the sleeping mat). But I couldn't really figure out a reason.

@joostlek joostlek merged commit 422252e into home-assistant:dev Oct 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
@vangorra vangorra deleted the vangorra_remove_codeowner_withings branch October 26, 2023 00:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants