Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monzo integration #101731

Merged
merged 45 commits into from
May 7, 2024
Merged

Conversation

JakeMartin-ICL
Copy link
Contributor

@JakeMartin-ICL JakeMartin-ICL commented Oct 9, 2023

Proposed change

This adds a new integration for Monzo, the UK bank. It provides balance and total balance sensors for each account and balance sensors for each pot. It also registers a webhook for transaction creation events which can be used as a device trigger, plus a simple service to transfer money between your own accounts and pots.

If you'd like to check out the integration on HACS, it can be found at: https://github.com/JakeMartin-ICL/ha-monzo/tree/main
The repo with the API wrapper is: https://github.com/JakeMartin-ICL/monzopy

Screenshots

image
Each account is shown in HA as a device

image
Each device has a balance sensor, plus a total balance if the account has pots

image
An example of an automation I use to keep my current account at a target I set, moving any excess to savings or pulling back into my current account if needed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.*

*not 100% coverage

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JakeMartin-ICL

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/monzo/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/__init__.py Show resolved Hide resolved
homeassistant/components/monzo/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/config_flow.py Show resolved Hide resolved
homeassistant/components/monzo/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/entity.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/monzo/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/services.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 31, 2023 14:58
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

github-actions bot commented Mar 5, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Mar 5, 2024
@JakeMartin-ICL
Copy link
Contributor Author

Thanks for the reviews and apologies for the delay making changes, moving house has kept me busy since new year.
Commenting to keep the PR open as I should be able to return to this in a week or two

@github-actions github-actions bot removed the stale label Mar 6, 2024
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@JakeMartin-ICL JakeMartin-ICL force-pushed the monzo-integration branch 2 times, most recently from a8d6409 to 062d5e2 Compare April 19, 2024 15:26
@JakeMartin-ICL JakeMartin-ICL marked this pull request as ready for review April 19, 2024 15:26
@home-assistant home-assistant bot requested review from zweckj and joostlek April 19, 2024 15:26
@JakeMartin-ICL JakeMartin-ICL marked this pull request as ready for review April 26, 2024 12:21
@home-assistant home-assistant bot requested a review from emontnemery April 26, 2024 12:21
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JakeMartin-ICL 👍

@emontnemery emontnemery merged commit 6e024d5 into home-assistant:dev May 7, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants