Add breeze switch to Renson integration

[jimmyd-be]

Breaking change

Proposed change

Added breeze switch to manually switch to breeze mode of the ventilcation unit.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add switch to Renson integration home-assistant.io#31462

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[emontnemery]

@jimmyd-be Please try to better explain what this PR does. Is it in reality a single renson device, which you want to model as two fan entities? If that's the case, why is that?

[krmarien]

I added on the original version of this component (when it was not yet home-assistant/core) the breeze feature with a switch. https://github.com/krmarien/Home-Assistant-Sensor-Renson-Ventilation/tree/breeze

To me that makes more sense as this is still one physical device (fan), it will just toggle some valves if I'm right.

[emontnemery]

I'm marking this PR as draft since there are open questions about the implementation.
@jimmyd-be Please reply to the questions, then click the "Ready for review" button 👍

[jimmyd-be]

This thread contains the most info #101641 (comment)

[jimmyd-be]

I added on the original version of this component (when it was not yet home-assistant/core) the breeze feature with a switch. https://github.com/krmarien/Home-Assistant-Sensor-Renson-Ventilation/tree/breeze

To me that makes more sense as this is still one physical device (fan), it will just toggle some valves if I'm right.

I first used your implementation but after first review it was not OK for the comunity. And changed after that to the current implementation.

[jimmyd-be]

@jimmyd-be Please try to better explain what this PR does. Is it in reality a single renson device, which you want to model as two fan entities? If that's the case, why is that?

It is a single device. And the device can push air from outside to inside and visa versa. The breeze function is for pushing outside air into the home for cooling. The normal fan is for filtering the air and with a temperature value to retain the temperature inside the house.

[emontnemery]

sorry @jimmyd-be, I didn't realize the recommendation to model the breeze mode as an additional fan came from review comments.

[jimmyd-be]

sorry @jimmyd-be, I didn't realize the recommendation to model the breeze mode as an additional fan came from review comments.

No problem, what do I need to change now? Keep this implementation or revert back to the switch and fan implementation?

[emontnemery]

@jimmyd-be I'll check with @joostlek and a few others.

[joostlek]

Just had a quick chat with Erik, and I want to apologise for the wrong recommendation. Back then I didn't know the things I know today.

I think having 1 fan entity like we already had and then have a switch or select to switch the mode would be the best.

[emontnemery]

@jimmyd-be please update the title and the description of the PR to match the implementation

[jimmyd-be]

@jimmyd-be please update the title and the description of the PR to match the implementation

Update the PR title and description. Reverted the code back to the previous commit.

[emontnemery]

Looks good to me, just one question.

[emontnemery]

LGTM, thanks @jimmyd-be 👍