Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict typing to GPSD #100030

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Add strict typing to GPSD #100030

merged 4 commits into from
Sep 12, 2023

Conversation

jrieger
Copy link
Contributor

@jrieger jrieger commented Sep 10, 2023

Proposed change

Add strict typing to GPSD

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (gpsd) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of gpsd can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign gpsd Removes the current integration label and assignees on the pull request, add the integration domain after the command.

homeassistant/components/gpsd/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/gpsd/sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 10, 2023 09:39
@jrieger jrieger marked this pull request as ready for review September 10, 2023 14:28
epenet
epenet previously requested changes Sep 11, 2023
homeassistant/components/gpsd/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 11, 2023 09:11
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@jrieger jrieger marked this pull request as ready for review September 11, 2023 09:15
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jrieger 👍

../Frenck

@frenck frenck merged commit f2fac40 into home-assistant:dev Sep 12, 2023
17 checks passed
@jrieger jrieger deleted the gpsd_typing branch September 13, 2023 04:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants