History Stats doesn't work #71593

MikaelHoogen · 2022-05-09T13:20:27Z

The problem

Since the update to 2022.5 the history stats integration doesn't work properly. The first day it counted up time constantly regardless of the state of the entity_id. After midnight it stopped counting completely. When I restart HA it is updated the first minutes. Then it stops again.

What version of Home Assistant Core has the issue?

2022.5.3

What was the last working version of Home Assistant Core?

2022.4.x

What type of installation are you running?

Home Assistant OS

Integration causing the issue

History Stats

Link to integration documentation on our website

https://www.home-assistant.io/integrations/history_stats/

Diagnostics information

No response

Example YAML snippet

- platform: history_stats
    name: heatpump_compressor_today
    entity_id: binary_sensor.heatpump_compressor_state
    state: "on"
    type: time
    start: "{{ now().replace(hour=0, minute=0, second=0, microsecond=0) }}"
    end: "{{ now().replace(microsecond=0) }}"

Anything in the logs that might be useful for us?

Nothing in the logs

Additional information

No response

probot-home-assistant · 2022-05-09T13:20:30Z

history_stats documentation
history_stats source
_{^{(message by IssueLinks)}}

bdraco · 2022-05-09T20:19:25Z

Does it work if you change end: "{{ now().replace(microsecond=0) }}" to a duration: 24:00:00

gideonyong · 2022-05-10T02:33:19Z

I have the same issue.
my yaml looks like this:

platform: history_stats
name: toggle_dryingmachine
entity_id: binary_sensor.dryingmachine_status
state: 'on'
type: time
start: '{{ as_timestamp(states.binary_sensor.dryingmachine_status.last_changed) }}'
end: '{{ as_timestamp(now()) }}'

chupacabra71 · 2022-05-10T13:02:39Z

Current Version: 2022.5.3
Last Working Version: Unknown
Install Type: Home Assistant OS
Integration: History Stats
Integration Link: https://www.home-assistant.io/integrations/history_stats/
YAML snippet

  - platform: history_stats
    name: Thermostat Heating Today Upstairs
    entity_id: sensor.hvac_activity_upstairs
    state: 'heating'
    type: time
    start: '{{ now().replace(hour=0, minute=0, second=0) }}'
    end: '{{ now() }}'

Additional Info: I can see the sensor data in the history, so recorder is working.

tomlut · 2022-05-10T13:16:44Z

The post by chpacabra71 was solved as an issue with the sensor.hvac_activity_upstairs sensor state.

bdraco · 2022-05-10T13:17:57Z

I've spent a few hours with no luck replicating this. All of mine are working no matter how hard I try to break them. I'm not discounting that there is an issue here, I've just been unable to replicate it.

bdraco · 2022-05-10T13:28:20Z

In case it was my dev install, I also just tried it on my production instance.

@MikaelHoogen Can you post a dump of the binary_sensor.heatpump_compressor_state state from the developer tools?

MikaelHoogen · 2022-05-10T13:59:15Z

Does it work if you change end: "{{ now().replace(microsecond=0) }}" to a duration: 24:00:00

Hi, with this change it seem to work. Kinda strange

bdraco · 2022-05-10T14:01:20Z

Which time zone is your instance running in?

bdraco · 2022-05-10T14:05:24Z

Here's what mine looks like when I paste your templates into developer tools

MikaelHoogen · 2022-05-10T14:06:56Z

In case it was my dev install, I also just tried it on my production instance.

@MikaelHoogen Can you post a dump of the binary_sensor.heatpump_compressor_state state from the developer tools?

Around 13:30 I did the change, end: "{{ now().replace(microsecond=0) }}" to a duration: 24:00:00

png">

MikaelHoogen · 2022-05-10T14:09:44Z

{{ now().replace(microsecond=0) }}

bdraco · 2022-05-10T14:11:38Z

I think we have a race condition here

        now_timestamp = floored_timestamp(datetime.datetime.now())

        if now_timestamp < current_period_start_timestamp:
            # History cannot tell the future
            self._history_current_period = []
            self._previous_run_before_start = True

MikaelHoogen · 2022-05-10T14:14:04Z

I think we have a race condition here

        now_timestamp = floored_timestamp(datetime.datetime.now())

        if now_timestamp < current_period_start_timestamp:
            # History cannot tell the future
            self._history_current_period = []
            self._previous_run_before_start = True

Hm I don't understand, can you elaborate?

bdraco · 2022-05-10T14:17:15Z

Can you try this change?

diff --git a/homeassistant/components/history_stats/data.py b/homeassistant/components/history_stats/data.py
index 3f22f4cc32..6a10345df1 100644
--- a/homeassistant/components/history_stats/data.py
+++ b/homeassistant/components/history_stats/data.py
@@ -67,9 +67,10 @@ class HistoryStats:
         current_period_end_timestamp = floored_timestamp(current_period_end)
         previous_period_start_timestamp = floored_timestamp(previous_period_start)
         previous_period_end_timestamp = floored_timestamp(previous_period_end)
-        now_timestamp = floored_timestamp(datetime.datetime.now())
+        utc_now = dt_util.utcnow()
+        now_timestamp = floored_timestamp(utc_now)
 
-        if now_timestamp < current_period_start_timestamp:
+        if current_period_start > utc_now:
             # History cannot tell the future
             self._history_current_period = []
             self._previous_run_before_start = True

bdraco · 2022-05-10T15:33:27Z

When you had the issue was the state 0 or unknown?

- history_stats ignores microseconds but it was not doing it for state_changed events Fixes home-assistant#71593

atjshop · 2022-05-12T03:00:27Z

Can you try this change?

diff --git a/homeassistant/components/history_stats/data.py b/homeassistant/components/history_stats/data.py
index 3f22f4cc32..6a10345df1 100644
--- a/homeassistant/components/history_stats/data.py
+++ b/homeassistant/components/history_stats/data.py
@@ -67,9 +67,10 @@ class HistoryStats:
         current_period_end_timestamp = floored_timestamp(current_period_end)
         previous_period_start_timestamp = floored_timestamp(previous_period_start)
         previous_period_end_timestamp = floored_timestamp(previous_period_end)
-        now_timestamp = floored_timestamp(datetime.datetime.now())
+        utc_now = dt_util.utcnow()
+        now_timestamp = floored_timestamp(utc_now)
 
-        if now_timestamp < current_period_start_timestamp:
+        if current_period_start > utc_now:
             # History cannot tell the future
             self._history_current_period = []
             self._previous_run_before_start = True

I'm using image homeassistant/home-assistant:stable, is there a way for me to make this change manually? I am able to login into the container by "docker exec" command but don't know where this file located.

bdraco · 2022-05-12T03:05:56Z

@atjshop Can you post a copy of your yaml config ?

atjshop · 2022-05-12T03:20:14Z

+        if current_period_start > utc_now:

I found it, after login into docker container, the file location is at usr/src/homeassistant/homeassistant/components/history_stats/

thanks.

unwasted · 2022-06-04T13:03:22Z

Hi!

This fix is still not in dev:
https://github.com/home-assistant/core/blob/dev/homeassistant/components/history_stats/data.py

This fixed the problem ...

Can you try this change?

diff --git a/homeassistant/components/history_stats/data.py b/homeassistant/components/history_stats/data.py
index 3f22f4cc32..6a10345df1 100644
--- a/homeassistant/components/history_stats/data.py
+++ b/homeassistant/components/history_stats/data.py
@@ -67,9 +67,10 @@ class HistoryStats:
         current_period_end_timestamp = floored_timestamp(current_period_end)
         previous_period_start_timestamp = floored_timestamp(previous_period_start)
         previous_period_end_timestamp = floored_timestamp(previous_period_end)
-        now_timestamp = floored_timestamp(datetime.datetime.now())
+        utc_now = dt_util.utcnow()
+        now_timestamp = floored_timestamp(utc_now)
 
-        if now_timestamp < current_period_start_timestamp:
+        if current_period_start > utc_now:
             # History cannot tell the future
             self._history_current_period = []
             self._previous_run_before_start = True

I'm using image homeassistant/home-assistant:stable, is there a way for me to make this change manually? I am able to login into the container by "docker exec" command but don't know where this file located.

While its been like this for a long time https://github.com/home-assistant/core/blob/5df747276f3a1b787c24b3225c457ca55bb5c84d/homeassistant/components/history_stats/sensor.py#L203 it fixes the issue reported here: home-assistant#71593 (comment)

bdraco · 2022-06-04T23:47:19Z

@unwasted Its in 2022.6.2 via #73040

probot-home-assistant bot added the integration: history_stats label May 9, 2022

bdraco self-assigned this May 9, 2022

bdraco mentioned this issue May 10, 2022

Add additional test cover for history_stats #71648

Merged

22 tasks

bdraco added a commit to bdraco/home-assistant that referenced this issue May 11, 2022

Prevent history_stats from rejecting states when microseconds differ

1a1c264

- history_stats ignores microseconds but it was not doing it for state_changed events Fixes home-assistant#71593

bdraco mentioned this issue May 11, 2022

Prevent history_stats from rejecting states when microseconds differ #71704

Merged

22 tasks

balloob closed this as completed in #71704 May 12, 2022

bdraco mentioned this issue Jun 4, 2022

Fix history stats not comparing all times in UTC #73040

Merged

22 tasks

github-actions bot locked and limited conversation to collaborators Jul 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

History Stats doesn't work #71593

History Stats doesn't work #71593

MikaelHoogen commented May 9, 2022

probot-home-assistant bot commented May 9, 2022

bdraco commented May 9, 2022

gideonyong commented May 10, 2022

chupacabra71 commented May 10, 2022

tomlut commented May 10, 2022

bdraco commented May 10, 2022

bdraco commented May 10, 2022

MikaelHoogen commented May 10, 2022

bdraco commented May 10, 2022

bdraco commented May 10, 2022

MikaelHoogen commented May 10, 2022 •

edited

Loading

MikaelHoogen commented May 10, 2022

bdraco commented May 10, 2022

MikaelHoogen commented May 10, 2022

bdraco commented May 10, 2022

bdraco commented May 10, 2022

atjshop commented May 12, 2022

bdraco commented May 12, 2022

atjshop commented May 12, 2022

unwasted commented Jun 4, 2022

bdraco commented Jun 4, 2022

History Stats doesn't work #71593

History Stats doesn't work #71593

Comments

MikaelHoogen commented May 9, 2022

The problem

What version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Diagnostics information

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

probot-home-assistant bot commented May 9, 2022

bdraco commented May 9, 2022

gideonyong commented May 10, 2022

chupacabra71 commented May 10, 2022

tomlut commented May 10, 2022

bdraco commented May 10, 2022

bdraco commented May 10, 2022

MikaelHoogen commented May 10, 2022

bdraco commented May 10, 2022

bdraco commented May 10, 2022

MikaelHoogen commented May 10, 2022 • edited Loading

MikaelHoogen commented May 10, 2022

bdraco commented May 10, 2022

MikaelHoogen commented May 10, 2022

bdraco commented May 10, 2022

bdraco commented May 10, 2022

atjshop commented May 12, 2022

bdraco commented May 12, 2022

atjshop commented May 12, 2022

unwasted commented Jun 4, 2022

bdraco commented Jun 4, 2022

MikaelHoogen commented May 10, 2022 •

edited

Loading