Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly returning “sunny” instead of “clear-night” #68369

Closed
21Development opened this issue Mar 19, 2022 · 4 comments · Fixed by #103334
Closed

Incorrectly returning “sunny” instead of “clear-night” #68369

21Development opened this issue Mar 19, 2022 · 4 comments · Fixed by #103334

Comments

@21Development
Copy link

The problem

This integration is returning the weather condition as “sunny” when it’s dark outside. I compared to the Met Office integration which correctly showed “clear-night” at the same times.

What version of Home Assistant Core has the issue?

core-2022.3.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Meteorologisk institutt (Met.no)

Link to integration documentation on our website

https://www.home-assistant.io/integrations/met

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Developer tools shows this for Met.no at midnight:
 - condition: sunny
    precipitation: 0
    temperature: 5.6
    datetime: '2022-03-20T00:00:00+00:00'
    wind_bearing: 102.8
    wind_speed: 21.2


And this for Met Office (which is correct)

 - datetime: '2022-03-20T00:00:00+00:00'
    condition: clear-night
    precipitation_probability: 0
    temperature: 5
    wind_bearing: E
    wind_speed: 11

Additional information

No response

@probot-home-assistant
Copy link

met documentation
met source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @Danielhiversen, @thimic, mind taking a look at this issue as it has been labeled with an integration (met) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@21Development
Copy link
Author

21Development commented Mar 19, 2022

Just checking other weather forecasts for this location and noticed they all change after sunset to a moon symbol, then back to sun after sunrise. (Whereas Met.no shows a Sun symbol throughout the night)

Thought I would mention in case this bug with met.no is related to checking sunset/sunrise !?

@21Development
Copy link
Author

Issue still exists

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
jrieger added a commit to jrieger/home-assistant-core that referenced this issue Nov 3, 2023
jpbede added a commit that referenced this issue Nov 4, 2023
* Report correct weather condition at night for Met, fixes #68369, fixes #89001

* Update homeassistant/components/met/weather.py

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>

---------

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
frenck pushed a commit that referenced this issue Nov 4, 2023
* Report correct weather condition at night for Met, fixes #68369, fixes #89001

* Update homeassistant/components/met/weather.py

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>

---------

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants