0.91.0 Daikin Errors "Entity id already exists"

[mynameisdaniel32]

Home Assistant release with the issue:
0.91.0

Last working Home Assistant release (if known):
0.90.2

Operating environment (Hass.io/Docker/Windows/etc.):
Linux Debian, venv

Component/platform:
Daikin

Description of problem:
Since updating to 0.91.0, on Home Assistant startup I get the below errors. Daikin loads correctly and I can see the climate and two sensor entities.

Tried deleting the entity registry entries for these, they get generated again without a problem (including unique IDs as far as I can tell).

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
Using the integrations panel to configure this, no Daikin YAML entry.

N/A

Traceback (if applicable):

2019-04-04 10:33:02 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 357, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: sensor.temperature_ac_bedroom_inside. Platform daikin does not generate unique IDs



2019-04-04 10:33:02 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 357, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: sensor.temperature_ac_bedroom_outside. Platform daikin does not generate unique IDs



2019-04-04 10:33:02 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 357, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: climate.ac_bedroom. Platform daikin does not generate unique IDs

Additional information:

[robbiet480]

@fredrike Is this a possible breaking change that went unnoticed in 0.91? Not seeing anything in the logs or your PRs and don't know enough about Daikin to be sure.

[fredrike]

@mynameisdaniel32 which type of AC unit do you have?

Tried deleting the entity registry entries for these, they get generated again without a problem (including unique IDs as far as I can tell).

Did this work even after a couple of restarts of HA?

@fredrike Is this a possible breaking change that went unnoticed in 0.91? Not seeing anything in the logs or your PRs and don't know enough about Daikin to be sure.

No nothing have changed in terms of unique ids, I'm really puzzled on what is going on here.

[lance36]

I also have the same messages on startup.

Looks like there is also a duplicate entry?

this is all i have in my config:

  hosts:
    - 192.168.1.108
    - 192.168.1.111
    - 192.168.1.115

Logs:

2019-04-04 22:38:56 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 357, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: sensor.outside_temperature_studio_outside_temperature. Platform daikin does not generate unique IDs
2019-04-04 22:38:56 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 357, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: sensor.inside_temperature_studio_inside_temperature. Platform daikin does not generate unique IDs
2019-04-04 22:38:57 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 357, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: climate.studio. Platform daikin does not generate unique IDs

[mynameisdaniel32]

@mynameisdaniel32 which type of AC unit do you have?

I've got an AU Daikin Zena, running the BRP072A42 module. Has been working for all previous versions (since the initial release of the Daikin component).

Tried deleting the entity registry entries for these, they get generated again without a problem (including unique IDs as far as I can tell).

Did this work even after a couple of restarts of HA?

No change after a few restarts. Maybe I should try clearing out the integration itself to start again? I'll try to work that out now.

If you do a search for GitHub issues with "Entity id already exists" there's a lot of them for other components, maybe something wider is afoot?

[fredrike]

It would be interesting to see what you had in your .storage/core.config_entries and core.entity_registry both before and after "cleaning" but I guess the before would be quite hard to find now.

Edit: Do you use the discovery module?

[lance36]

Updated to 0.91.1 and still had those nasty messages :)

i had a duplicate entry in core.config_entries

            {
                "connection_class": "local_poll",
                "data": {
                    "host": "192.168.1.108",
                    "mac": "<redacted>"
                },
                "domain": "daikin",
                "entry_id": "bdfac417dd9d48fa8762d72a1b97edd7",
                "options": {},
                "source": "import",
                "title": "192.168.1.108",
                "version": 1
            },
...
            {
                "connection_class": "local_poll",
                "data": {
                    "host": "192.168.1.108",
                    "mac": null
                },
                "domain": "daikin",
                "entry_id": "bd70e3cb836e4290976e11ac3a6845b2",
                "options": {},
                "source": "import",
                "title": "192.168.1.108",
                "version": 1
            } 

i still get this message:

2019-04-05 19:34:20 ERROR (MainThread) [homeassistant.components.daikin.config_flow] Unexpected error creating device
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/daikin/config_flow.py", line 46, in _create_device
    await device.init()
  File "/srv/homeassistant/lib/python3.5/site-packages/pydaikin/appliance.py", line 184, in init
    await self.update_status(HTTP_RESOURCES[:1])
  File "/srv/homeassistant/lib/python3.5/site-packages/pydaikin/appliance.py", line 220, in update_status
    self.values.update(await self.get_resource(resource))
  File "/srv/homeassistant/lib/python3.5/site-packages/pydaikin/appliance.py", line 203, in get_resource
    return await self._get_resource(resource)
  File "/srv/homeassistant/lib/python3.5/site-packages/pydaikin/appliance.py", line 212, in _get_resource
    'http://%s/%s' % (self.ip, resource)) as resp:
  File "/srv/homeassistant/lib/python3.5/site-packages/aiohttp/client.py", line 1005, in __aenter__
    self._resp = await self._coro
  File "/srv/homeassistant/lib/python3.5/site-packages/aiohttp/client.py", line 497, in _request
    await resp.start(conn)
  File "/srv/homeassistant/lib/python3.5/site-packages/aiohttp/client_reqrep.py", line 844, in start
    message, payload = await self._protocol.read()  # type: ignore  # noqa
  File "/srv/homeassistant/lib/python3.5/site-packages/aiohttp/streams.py", line 588, in read
    await self._waiter
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
aiohttp.client_exceptions.ServerDisconnectedError: None

but everything seems to be working anyhow