Shelly Plus Smoke configured but without entities (reopened)

[ezcGman]

The problem

This is basically a re-open of this issue, as the maintainer does not respond after multiple taggings: #117818

The issue is, that Shelly Plus Smokes are added without any entities. That happens in 90% of the cases, sometimes they do get entities, after you retry a lot of times. I could not find a pattern what makes them appear after the Xth retry.

However, I have been able to kinda reproduce it while debug logging was enabled, please see the attached logfile.
What I've done during the timeframe the log shows:

• Added the Shelly Plus Smoke with IP 10.42.200.45 via discovery config flow
• After adding, the device had no entities, just the devive
• I tried hitting the "Reload" button on the device multiple times, no change. I did that because for another Shelly Smoke that eventually fixed that one.
• I waited until the device went back to sleep, then woke it up and immediately tried "Reload" and it had entities. Maybe the entities already appeared without me hitting reload and just waking up added them... I don't know

It's very easy to not get entities when adding a Shelly Plus Smoke, so it should be easy reproduceable.

I'm happy to help and try to reproduce and collect more info / logs!

What version of Home Assistant Core has the issue?

core-2024.8.1

What was the last working version of Home Assistant Core?

core-2024.8.1

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Shelly

Link to integration documentation on our website

https://www.home-assistant.io/integrations/shelly/

Diagnostics information

shelly-smoke.log

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Please see text in "The problem" above

Additional information

Please see text in "The problem" above

[home-assistant]

Hey there @balloob, @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this issue as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign shelly Removes the current integration label and assignees on the issue, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

shelly documentation
shelly source
_{^{(message by IssueLinks)}}

[HaraldGithub]

@ezcGman

Do you have configured the "outbound wegsocket" of the shelly smoke like this
ws://IP_of_our_homeassistant:8123/api/shelly/ws

[ezcGman]

Yes. (Probably) Otherwise it would never get entities. But it does after multiple (a lot!) of retries.

[thecode]

@ezcGman I have identified some issue in your logs when reloading the device, however it is probably not the cause for this issue.

Can you please re-run the command in #123399 (comment) to update, restart HA and try to reproduce the issue?

Thanks.

[ezcGman]

Hey @thecode,

First: Thanks for the reply and help here!

I've just ran that command and installed that version as custom component confirmed it's loaded on startup: 2024-08-18 21:27:36.080 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration shelly which has not been tested by Home Assistant.

I tried it two times with nearly the same results and the same device (10.42.200.45) (tl;dr: after adding the Smoke Sensor no entities, but after some time):

Test 1:
home-assistant_shelly_2024-08-18T19-48-27.218Z.log

• I removed the Shelly Plus Smoke
• Rebooted HA
• Woke up the Plus Smoke from sleep
• Waited until it got discovered
• Added / Configured it and it had no entities
• I wanted to wait until it goes back to sleep and wake it up again to see if that adds entities, but shortly before it should have went to sleep, it got entities in HA and it felt like that it took longer now until it went to sleep, like the API calls made my the integration probably kept it alive longer

Test 2:
home-assistant_shelly_2024-08-18T19-53-38.008Z.log

• I removed the same Shelly Plus Smoke
• Rebooted HA
• Woke up the Plus Smoke from sleep
• Waited until it got discovered (around 21:51:xx)
• Added / Configured it and it had no entities
• I again waited for it to go to sleep. When it went back to sleep, I woke it up, waited some time and it got entities in HA (21:53:xx)

So it feeeellllsss like it's at least now more reproducable? I can try it with a fresh / new Plus Smoke, if that helps? Also of course happy to do any other tests!

Greetings,

Andy!

[thecode]

Thanks @ezcGman, from you logs, while it is not the best user experience there is nothing different that what is currently happen with sleeping devices.

When you first wake the device HA detect the device, but we only collect the minimum data from the device to allow adding it.
When you add the device we just mark it as added (without entities) and wait for it to wake up again so we can collect all data from it. Although you are correct that the device is still awake, we don't really know it.
It can happen that hours pass from when the device was detected until you confirmed it in the UI.
On the 2nd wakeup device is already added so we collect all data to create entities.
From your log:
First step when you added the device:

2024-08-18 21:51:24.262 DEBUG (MainThread) [custom_components.shelly] Setup for device smoke-alarm-level-1-corridor will resume when device is online

Second step when we detect the device is online and create the entities:

2024-08-18 21:53:30.160 DEBUG (MainThread) [custom_components.shelly] Device smoke-alarm-level-1-corridor is online, resuming setup

I will try to think of a logic to try to fetch data on the first step assuming the device may be online/offline and report back here, but anyhow this is not a specific bug for your case.

[ezcGman]

Hey @thecode

sorry for the late reply! Totally forgot it...

When you first wake the device HA detect the device, but we only collect the minimum data from the device to allow adding it.
When you add the device we just mark it as added (without entities) and wait for it to wake up again so we can collect all data from it.

Why is it done this way though? Why is it required to wait until next wakeup? If you fetch the minimum data, why not directly fetch whatever you do when it wakes up again. You can still try/except it. If it works, it works, if not, it's tried after waking up again.

Thanks and greetings,

Andy!

[bdraco]

#124547 should fix this after the next wake up. Ideally we would create them a bit faster but that would be a much more invasive change