Strip trailing / from OTBR url (#124223)

home-assistant · Aug 19, 2024 · 110ee9f · 110ee9f
1 parent c76d685
commit 110ee9f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/homeassistant/components/otbr/config_flow.py b/homeassistant/components/otbr/config_flow.py
@@ -111,7 +111,7 @@ async def async_step_user(
         errors = {}
 
         if user_input is not None:
-            url = user_input[CONF_URL]
+            url = user_input[CONF_URL].rstrip("/")
             try:
                 await self._connect_and_set_dataset(url)
             except (
@@ -124,7 +124,7 @@ async def async_step_user(
                 await self.async_set_unique_id(DOMAIN)
                 return self.async_create_entry(
                     title="Open Thread Border Router",
-                    data=user_input,
+                    data={CONF_URL: url},
                 )
 
         data_schema = vol.Schema({CONF_URL: str})

diff --git a/tests/components/otbr/test_config_flow.py b/tests/components/otbr/test_config_flow.py
@@ -49,17 +49,25 @@ def addon_info_fixture():
         yield addon_info
 
 
+@pytest.mark.parametrize(
+    "url",
+    [
+        "http://custom_url:1234",
+        "http://custom_url:1234/",
+        "http://custom_url:1234//",
+    ],
+)
 async def test_user_flow(
-    hass: HomeAssistant, aioclient_mock: AiohttpClientMocker
+    hass: HomeAssistant, aioclient_mock: AiohttpClientMocker, url: str
 ) -> None:
     """Test the user flow."""
-    url = "http://custom_url:1234"
-    aioclient_mock.get(f"{url}/node/dataset/active", text="aa")
+    stripped_url = "http://custom_url:1234"
+    aioclient_mock.get(f"{stripped_url}/node/dataset/active", text="aa")
     result = await hass.config_entries.flow.async_init(
         otbr.DOMAIN, context={"source": "user"}
     )
 
-    expected_data = {"url": url}
+    expected_data = {"url": stripped_url}
 
     assert result["type"] is FlowResultType.FORM
     assert result["errors"] == {}