Make sure builder image is pulled by default #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sairon
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM, although it was fundamentally wrong (because of the inverted condition), it should also be a string.
Avoid double negation which is error prone.
sairon
requested changes
Aug 14, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jan Čermák <sairon@users.noreply.github.com>
sairon
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly pull the image by default.
The if expression was really wrong. This hasn't been noticed in #214 since the comparison with true == "true" indeed lead to the step not being executed. The GitHub Action syntax doesn't support boolean inputs. Make this explicit using strings.