Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nordpool logos (and add copies to Nordpool Planner) #5898

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

dala318
Copy link
Contributor

@dala318 dala318 commented Sep 23, 2024

Proposed change

Nordpool has got new logos, change to the new graphic profile.
Add the same logos for Nordpool Planner

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: Nordpool & Nordpool Planner

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@dala318 dala318 mentioned this pull request Sep 23, 2024
13 tasks
@dala318 dala318 marked this pull request as ready for review September 30, 2024 06:48
@dala318
Copy link
Contributor Author

dala318 commented Sep 30, 2024

For now I have made copies of the same logos and icons in both custom_component nordpool and nordpool_planner as they should have the same icons. Would it work out (and need less future maintenance) if I made a folder sym-link for the "child integration" Nordpool Planner?

@dala318
Copy link
Contributor Author

dala318 commented Sep 30, 2024

Ping @Hellowlol about change in Nordpool

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @dala318 👍

../Frenck

@frenck frenck merged commit c06a9c8 into home-assistant:master Sep 30, 2024
5 checks passed
@dala318 dala318 deleted the nordpool_planner_2 branch September 30, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants