Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for SK Svatek sensor #5862

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Add icons for SK Svatek sensor #5862

merged 10 commits into from
Sep 23, 2024

Conversation

LochyCZ
Copy link
Contributor

@LochyCZ LochyCZ commented Sep 15, 2024

Proposed change

Type of change

  • [] Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

SK Svatek sensor

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@LochyCZ LochyCZ changed the title Add icons for SK Svatek sensor Add icons for SK Svatek sensor and FioBank sensor Sep 15, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains multiple integrations. Please split it out into multiple PRs with 1 integration per pull request.

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft September 16, 2024 07:07
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@LochyCZ LochyCZ marked this pull request as ready for review September 19, 2024 19:20
@LochyCZ
Copy link
Contributor Author

LochyCZ commented Sep 19, 2024

Updated

@edenhaus edenhaus changed the title Add icons for SK Svatek sensor and FioBank sensor Add icons for SK Svatek sensor Sep 19, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LochyCZ 👍

../Frenck

@frenck frenck merged commit e242a54 into home-assistant:master Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants