-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for HueBLE #5534
base: master
Are you sure you want to change the base?
Add icons for HueBLE #5534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just use the already available Hue Logos? Create a symlink pointing from hue_ble to hue
I would have done that but I already spent the effort making the logo for the Python library for the Home Assistant integration and it only took a few minutes to crop it for this and I wanted a little bit of differentiation from the bridge based integration and my Bluetooth based one, and also to highlight my work a little, even though its a minor thing, I can live without it though if its important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains product images; however, we collect manufacturer branding in this repository. In this case, the Philips Hue branding was expected to be used.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@frenck Phillips do have branding specific to their Bluetooth lights if that works better |
Proposed change
Add icon and logo for the proposed new intergration HueBLE
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)