Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bluelink logo - custom integration #4983

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

TaiPhamD
Copy link
Contributor

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • I've opened up a PR for my custom integration on the Home Assistant
    Python wheels repository
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@klaasnicolaas klaasnicolaas changed the title logo Add Bluelink logo - custom integration Dec 13, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you added Application icons, instead of manufacturer branding. In this case, I would have expected Hyundai branding?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 13, 2023 18:34
@TaiPhamD
Copy link
Contributor Author

It seems like you added Application icons, instead of manufacturer branding. In this case, I would have expected Hyundai branding?

../Frenck

Oops, misunderstood the purpose of brands. I have updated to a bluelink/hyundai logo .

@TaiPhamD TaiPhamD marked this pull request as ready for review December 15, 2023 01:00
@home-assistant home-assistant bot requested a review from frenck December 15, 2023 01:00
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TaiPhamD 👍

../Frenck

@frenck frenck merged commit 3a0cca8 into home-assistant:master Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants