Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Feb 9, 2026

Summary

We were using renovate to update our lockfile but this doesn't work for modules that uses the NDK like :microfrontend that we've just introduced #6312. Also I found out that sometimes renovate was only making partial update of the lockfile since it was not using gradle to generate it. This new approach is cleaner from the Gradle perspective.

Now each time renovate open a PR a new GA workflow is triggered and commit if needed the lockfiles update.

Any other notes

We might need to fix some stuff after the first PR from renovate.

@TimoPtr
Copy link
Member Author

TimoPtr commented Feb 9, 2026

@jpelgrom that might be annoying since it is not going to trigger the CI like for the update of the screenshots...

@jpelgrom
Copy link
Member

jpelgrom commented Feb 9, 2026

@jpelgrom that might be annoying since it is not going to trigger the CI like for the update of the screenshots...

That sounds very annoying, now every dependency update would need a maintainer to do an empty push to trigger CI. It also hides any failures that the dependency update might cause until we make such a push, as the run before will fail because lockfiles changed.

@TimoPtr
Copy link
Member Author

TimoPtr commented Feb 9, 2026

@jpelgrom that might be annoying since it is not going to trigger the CI like for the update of the screenshots...

That sounds very annoying, now every dependency update would need a maintainer to do an empty push to trigger CI. It also hides any failures that the dependency update might cause until we make such a push, as the run before will fail because lockfiles changed.

I've tried something that might do the trick that is used for the release workflow. Let merge it and see if it works. If it works we should also adjust the manual workflow for the screenshots.

@jpelgrom
Copy link
Member

jpelgrom commented Feb 9, 2026

Where does this new token come from? (ie is it registered to an app or you personally)

https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow suggests "events triggered by the GITHUB_TOKEN (...) will not create a new workflow run.". The event that would trigger a workflow run here is push - so I think the commit action would need to use a different token?

name: Pull Request

on: # yamllint disable-line rule:truthy
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is actually helpful to be able to manually trigger this worfklow, like for the screenshot update instead of making a dumb or empty commit.

configMigration: true,
extends: [
'config:recommended',
'config:best-practices',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion from renovate for us to migrate to this config instead.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's see if this works and iterate from there so Renovate updates are a bit smoother again. Still not completely sold.

@TimoPtr TimoPtr enabled auto-merge (squash) February 9, 2026 17:51
@TimoPtr TimoPtr merged commit 06fc295 into main Feb 9, 2026
23 checks passed
@TimoPtr TimoPtr deleted the fix/renovate_setup branch February 9, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants