-
-
Notifications
You must be signed in to change notification settings - Fork 886
Use Github Action instead of renovate to update lockfile #6414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jpelgrom that might be annoying since it is not going to trigger the CI like for the update of the screenshots... |
That sounds very annoying, now every dependency update would need a maintainer to do an empty push to trigger CI. It also hides any failures that the dependency update might cause until we make such a push, as the run before will fail because lockfiles changed. |
I've tried something that might do the trick that is used for the release workflow. Let merge it and see if it works. If it works we should also adjust the manual workflow for the screenshots. |
|
Where does this new token come from? (ie is it registered to an app or you personally) https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow suggests "events triggered by the |
| name: Pull Request | ||
|
|
||
| on: # yamllint disable-line rule:truthy | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is actually helpful to be able to manually trigger this worfklow, like for the screenshot update instead of making a dumb or empty commit.
| configMigration: true, | ||
| extends: [ | ||
| 'config:recommended', | ||
| 'config:best-practices', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion from renovate for us to migrate to this config instead.
jpelgrom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's see if this works and iterate from there so Renovate updates are a bit smoother again. Still not completely sold.
Summary
We were using renovate to update our lockfile but this doesn't work for modules that uses the NDK like
:microfrontendthat we've just introduced #6312. Also I found out that sometimes renovate was only making partial update of the lockfile since it was not using gradle to generate it. This new approach is cleaner from the Gradle perspective.Now each time renovate open a PR a new GA workflow is triggered and commit if needed the lockfiles update.
Any other notes
We might need to fix some stuff after the first PR from renovate.