Catching wrong exception in ServerSettingsPresenter#6282
Merged
Conversation
Member
To be more specific, it looks like it is the result of #6212 |
jpelgrom
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the recent changes it turns out that we are catching the wrong exception while trying to setAppActive from the settings. This PR simply avoid the crash but doesn't fix the underlying issue that we should not try in the first place to setAppActive with an ID that doesn't exist. Which tells me that we should still proactively cleanup whatever that could lead to this scenario, probably with #6265.