Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zwave-js to 9.0.2 and zwave-js-server to 1.16.0 #2424

Merged
merged 6 commits into from
Apr 19, 2022

Conversation

raman325
Copy link
Collaborator

@raman325 raman325 commented Apr 4, 2022

This PR isn't working correctly yet which is why it's still in draft. Details after changelog. This has been resolved. According to this issue we need to build @serialport/bindings-cpp from source: serialport/node-serialport#2438

Changelog:

@raman325 raman325 marked this pull request as ready for review April 5, 2022 23:23
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should delay releasing this a couple of days after the core release to not potentially confuse users about what could be the reason for any issues that come up with their devices?

@raman325
Copy link
Collaborator Author

raman325 commented Apr 6, 2022

we can, but may want to check in with @frenck as well to see when he plans to release zwavejs2mqtt, there's no point delaying if the other one gets released anyway. I've messaged him on Discord and will report back here

@frenck
Copy link
Member

frenck commented Apr 7, 2022

🤷 I'm happy to adopt any schedule

@raman325
Copy link
Collaborator Author

raman325 commented Apr 9, 2022

EDIT: ignore what I said there's an inclusion bug that needs to be fixed in v9. We should probably add the fix here before we merge. Doesn't seem like there are any HA related problems though!

@raman325 raman325 changed the title Bump zwave-js to 9.0.1 and zwave-js-server to 1.16.0 Bump zwave-js to 9.0.2 and zwave-js-server to 1.16.0 Apr 15, 2022
@raman325
Copy link
Collaborator Author

this is ready to be merged.

@raman325
Copy link
Collaborator Author

can someone restart CI?

@MartinHjelmare
Copy link
Member

Another job failed this time.

@raman325
Copy link
Collaborator Author

Error: fatal: Could not read from remote repository. Seems like maybe a problem with CI and not with the PR?

@raman325
Copy link
Collaborator Author

all good now!

@MartinHjelmare MartinHjelmare merged commit 55fd0cb into home-assistant:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants