Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependent patch which introduces _DeviceAvailableCallback #52

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

agners
Copy link
Collaborator

@agners agners commented Mar 28, 2024

The patch which implements async GetConnectedDevice requires the _DeviceAvailableCallback which got introduced with the fix which keeps a reference to callback function when using a timeout.

Reorder the patch in a sensible order.

The main/v1.3 branch already has this change upstream.

The patch which implements async GetConnectedDevice requires the
_DeviceAvailableCallback which got introduced with the fix which
keeps a reference to callback function when using a timeout.

Reorder the patch in a sensible order.

The main/v1.3 branch already has this change upstream.
Copy link
Contributor

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agners agners merged commit aed5835 into release Mar 28, 2024
2 of 4 checks passed
@agners agners deleted the add-dependent-patch branch April 18, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants