feat(users): add libravatar / gravatar support #4277
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
| email: currentSession?.user.email ?? null, | ||
| }; | ||
|
|
||
| if (!user.image && !user.email && user.name) user.image = null; |
There was a problem hiding this comment.
Is there a reason for this? Can you explain?
There was a problem hiding this comment.
I guess it's redundant because of ?? null inside const user:.
I can remove that part yeah
| if (user.email) { | ||
| const emailHash = createHash("md5").update(user.email.trim().toLowerCase()).digest("hex"); | ||
| return <Avatar src={`https://seccdn.libravatar.org/avatar/${emailHash}?d=404`} alt={user.name} size={size} />; | ||
| } |
There was a problem hiding this comment.
I'll have to check if the usage of crypto actually works
Meierschlumpf
changed the title
I did add an extra user and the Libravatar/Gravatar works fine for that user too. I could be missing smth tho |
|
What I mean is that there are a lot of other user avatars that should also have the email always available, so you should make the email property required and add it to the missing places: 
|
|
Ah like that, fair. Gonna add it! |
|
Can you also add a toggle (setting) that enables Gravatar? Some people may not want it. |
Atm working on it |
3 participants
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm build, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)Closes #2783