feat: add widget feedback feature #2686
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
packages/modals-collection/src/feedback/widget-feedback-modal.tsx
Outdated
Show resolved
Hide resolved
| <Menu.Item leftSection={<IconMessageCircle2 size={16} />} onClick={openWidgetFeedbackModal}> | ||
| {tItem("action.feedback")} | ||
| </Menu.Item> |
There was a problem hiding this comment.
Render this conditionally, only when analytics are enabled
There was a problem hiding this comment.
Technically this is not analytics. We are just leveraging our umami endpoint to send feedback. It won't send anything else other than that form
There was a problem hiding this comment.
Hmm... in theory you're right, but we disable umami when you disabled analytics.
For the sake of transparency and integrity, I think we should keep doing it that way, hence disabling the feedback menu item.
There was a problem hiding this comment.
@Meierschlumpf @SeDemal what's your opinion on this ?
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ajnart
force-pushed
the
feat/client-give-feedback
branch
from
16a58b5 to
980f9de
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new widget feedback feature, allowing users to submit feedback on widgets when in edit mode, and exposes umami client functions for sending tracking data. Key changes include:
- Introducing a new widget feedback modal component with rating inputs and feedback submission.
- Updating module exports to include new feedback and docker modules.
- Adding a new integration route in the documentation sitemap and integrating the feedback modal into the board item menu.
Reviewed Changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/modals-collection/src/index.ts | Reorders and updates module exports for clarity. |
| packages/modals-collection/src/feedback/widget-feedback-modal.tsx | Creates a new feedback modal component with umami tracking integration. |
| packages/modals-collection/src/feedback/index.ts | Exposes the widget feedback modal through a new index file. |
| packages/definitions/src/docs/homarr-docs-sitemap.ts | Adds a new documentation path for cloud integrations. |
| apps/nextjs/src/components/board/items/item-menu.tsx | Integrates the new widget feedback modal into the board item menu with an updated icon. |
Files not reviewed (4)
- apps/nextjs/package.json: Language not supported
- packages/modals-collection/package.json: Language not supported
- packages/translation/src/lang/en.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/modals-collection/src/index.ts:1
- [nitpick] Consider grouping related module exports (e.g., apps, docker, invites) together consistently to improve clarity and maintainability.
export * from "./apps";
|
|
||
| actions.closeModal(); | ||
| } catch (error) { | ||
| console.error("Error sending feedback:", error); |
There was a problem hiding this comment.
Consider notifying the user of a submission error (for example by showing an error notification) instead of only logging the error to the console.
| console.error("Error sending feedback:", error); | |
| showErrorNotification({ | |
| title: t("notification.error.title"), | |
| message: t("notification.error.message"), | |
| }); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Actually not a bad idea
Add a "give feedback" on every widget when in edit mode.
Also exposes umami client functions that allows to send umami data through the client
Screen.Recording.2025-03-23.at.21.55.20-1-1-1.mov