Skip to content

Conversation

@jackwellerreal
Copy link
Contributor

@jackwellerreal jackwellerreal commented Mar 16, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes: #2233

example

@jackwellerreal jackwellerreal requested a review from a team as a code owner March 16, 2025 00:17
@deepsource-io
Copy link
Contributor

deepsource-io bot commented Mar 16, 2025

Here's the code health analysis summary for commits 18f845b..afc04e1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Meierschlumpf
Copy link
Member

I would like the title to be a badge so the size of the content is not getting smaller. See the issues image

@jackwellerreal
Copy link
Contributor Author

I would like the title to be a badge so the size of the content is not getting smaller. See the issues image

Is this possible with mantine

@Meierschlumpf
Copy link
Member

Sure, everything is possible. The screenshot I made also used Mantine

@jackwellerreal
Copy link
Contributor Author

image

Does this look good. I also made the max length 20 to disencourage the title overflowing

Meierschlumpf
Meierschlumpf previously approved these changes Mar 22, 2025
@Meierschlumpf
Copy link
Member

Let's wait for an approval from one of the other @homarr-labs/maintainers

@manuel-rw
Copy link
Member

Well done 👍

@jackwellerreal
Copy link
Contributor Author

Is this ready to be merged?

@manuel-rw
Copy link
Member

Is this ready to be merged?

If you got approvals and there are no conversations left, you can merge PRs.

@Meierschlumpf Meierschlumpf merged commit 1dd7b1a into homarr-labs:dev Mar 24, 2025
11 checks passed
@Meierschlumpf
Copy link
Member

Except that only maintainers can merge them 😉

@jackwellerreal jackwellerreal deleted the dynamic_title branch March 28, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add badge title to dynamic section

3 participants