Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed RingMapOnto* methods #613

Conversation

mohamed-barakat
Copy link
Member

No description provided.

@mohamed-barakat mohamed-barakat force-pushed the RingMapOntoSimplifiedResidueClassRing branch from aa0682d to 56ce507 Compare August 25, 2024 17:19
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.47%. Comparing base (3c67d56) to head (35d2300).
Report is 2 commits behind head on master.

Files Patch % Lines
MatricesForHomalg/gap/Tools.gi 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   70.48%   70.47%   -0.02%     
==========================================
  Files         437      437              
  Lines       72140    72155      +15     
==========================================
+ Hits        50847    50849       +2     
- Misses      21293    21306      +13     
Flag Coverage Δ
4ti2Interface 50.00% <ø> (ø)
ExamplesForHomalg 96.98% <ø> (ø)
Gauss 80.45% <ø> (ø)
GaussForHomalg 95.47% <ø> (ø)
GradedModules 79.47% <ø> (ø)
GradedRingForHomalg 72.74% <ø> (ø)
HomalgToCAS 72.15% <ø> (+0.09%) ⬆️
IO_ForHomalg 70.78% <ø> (ø)
LocalizeRingForHomalg 61.23% <ø> (ø)
MatricesForHomalg 69.84% <4.34%> (-0.07%) ⬇️
Modules 77.68% <ø> (ø)
RingsForHomalg 46.88% <ø> (ø)
SCO 80.27% <ø> (ø)
ToolsForHomalg 68.75% <ø> (ø)
homalg 73.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamed-barakat mohamed-barakat force-pushed the RingMapOntoSimplifiedResidueClassRing branch from 56ce507 to 35d2300 Compare August 25, 2024 18:37
@mohamed-barakat mohamed-barakat merged commit b6a3230 into homalg-project:master Aug 25, 2024
3 of 5 checks passed
@mohamed-barakat mohamed-barakat deleted the RingMapOntoSimplifiedResidueClassRing branch August 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant