Use (dp,c) as default ordering for Singular rings #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zickgraf
added a commit
to homalg-project/D-Modules
that referenced
this pull request
Apr 17, 2020
zickgraf
added a commit
to zickgraf/CAP_project
that referenced
this pull request
Apr 17, 2020
zickgraf
force-pushed
the
singular_performance
branch
from
8903fa0 to
d9ae399
Compare
|
Thank you very much Fabian. I will report any speed improvements or regressions I notice. |
|
The test suite of the Chevalley paper dropped from 126 sec wall time to 114 sec :) |
mohamed-barakat
added a commit
to homalg-project/HomalgProject.jl
that referenced
this pull request
Apr 18, 2020
See homalg-project/homalg_project#318: Use (dp,c) as default ordering for Singular rings
mohamed-barakat
added a commit
to homalg-project/HomalgProject.jl
that referenced
this pull request
Apr 18, 2020
See homalg-project/homalg_project#318: Use (dp,c) as default ordering for Singular rings
mohamed-barakat
added a commit
to homalg-project/HomalgProject.jl
that referenced
this pull request
Apr 18, 2020
See homalg-project/homalg_project#318: Use (dp,c) as default ordering for Singular rings
mohamed-barakat
added a commit
to homalg-project/HomalgProject.jl
that referenced
this pull request
Apr 18, 2020
See homalg-project/homalg_project#318 Use (dp,c) as default ordering for Singular rings
mohamed-barakat
added a commit
to homalg-project/HomalgProject.jl
that referenced
this pull request
Apr 18, 2020
See homalg-project/homalg_project#318: Use (dp,c) as default ordering for Singular rings
mohamed-barakat
added a commit
to homalg-project/HomalgProject.jl
that referenced
this pull request
Apr 18, 2020
See homalg-project/homalg_project#318: Use (dp,c) as default ordering for Singular rings
sebastianpos
added a commit
to homalg-project/CAP_project
that referenced
this pull request
Apr 20, 2020
mohamed-barakat
added a commit
to homalg-project/OscarForHomalg
that referenced
this pull request
Apr 27, 2020
mohamed-barakat
added a commit
to homalg-project/OscarForHomalg
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default ordering used for modules in Singular: by default, Singular uses
C(capital letter) which means that the last entry of a vector gets the biggest weight. With this PR, all rings usec(small letter) which means that the first entry of a vector gets the biggest weight. All operations computing transformations vectors (BasisOfRows/ColumnsCoeff,SyzygiesOfRows/Columns,Left/RightDivide) should benefit from this because of the way Singular computes transformation vectors. Other operations should be more or less unaffected. A trivial test case in which the runtime drops from >minutes to some seconds is included in the PR. In real applications the improvement depends on the concrete examples. Large examples should benefit more whereas for small examples there should be nearly no difference.Differences in tests are, of course, expected. The CI fails because
D-ModulesandModulePresentationsForCAPhave to be adapted. I will open PRs in the corresponding repos soon.@sebastianpos @kamalsaleh I would be interested if you notice a change of performance in your computations using this PR :-)