Stop using undocumented APIs #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will disappear once homalg gets rebased on CAP. |
|
Unless that is due very soon, it would still be good if you could merge this PR: The fact that homalg is using this undocumened kernel API (and for no good reason) means we have to stop plans to refactor it, as else we'd break homalg in the next GAP release... |
|
(OK, for now we have decided to not change that kernel API anyway, but it may come up again soonish...) |
|
+1 for merging this right now. This PR is not about removing or replacing |
|
Note: This operation was introduced by @markuslh |
HereAround
pushed a commit
to HereAround/homalg_project
that referenced
this pull request
Jun 18, 2020
Stop using undocumented APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, on the long run I'd urge you to consider getting rid of
DeclareAttributeWithCustomGetter, and stop abusing attributes forMorphismAid(the only thing using this)... :-). But that's of course a deeper change, requiring more testing, so.... :-)