Fix building on macOS and cygwin #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both need -lgmp added explicitly. Also, on cygwin, the headers are in /usr/include/cddlib, so let's search there, too (this matches what is done when `--with_cddlib` is given, too)
Closed
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 89.59% 89.59%
=======================================
Files 5 5
Lines 913 913
Branches 23 23
=======================================
Hits 818 818
Misses 91 91
Partials 4 4 |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both need -lgmp added explicitly. Also, on cygwin, the headers
are in /usr/include/cddlib, so let's search there, too (this matches
what is done when
--with_cddlibis given, too)Also resolves #25