Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer triggering derivations until Finalize #1691

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

zickgraf
Copy link
Member

This has already been proposed a long time ago in #144. There is only one drawback: Applying CanCompute to unfinalized categories now only takes primitive operations into account. This might require some minor changes as can be seen in AdditiveClosure.gi.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (f1c2f91) to head (973c992).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
CAP/gap/Finalize.gi 68.75% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         559      559           
  Lines       77235    77217   -18     
=======================================
- Hits        63889    63877   -12     
+ Misses      13346    13340    -6     
Flag Coverage Δ
ActionsForCAP 64.09% <100.00%> (ø)
AttributeCategoryForCAP 90.45% <ø> (ø)
CAP 86.23% <70.58%> (+0.01%) ⬆️
CartesianCategories 89.36% <ø> (ø)
CompilerForCAP 95.86% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.60% <ø> (ø)
FreydCategoriesForCAP 81.98% <100.00%> (-0.01%) ⬇️
GeneralizedMorphismsForCAP 61.81% <ø> (ø)
GradedModulePresentationsForCAP 44.62% <ø> (ø)
GroupRepresentationsForCAP 71.92% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.09% <ø> (ø)
LinearAlgebraForCAP 66.54% <ø> (ø)
ModulePresentationsForCAP 69.88% <ø> (ø)
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 89.70% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zickgraf zickgraf merged commit 78bcddb into homalg-project:master Sep 25, 2024
5 of 6 checks passed
zickgraf added a commit to zickgraf/FinSetsForCAP that referenced this pull request Sep 25, 2024
zickgraf added a commit to zickgraf/FinSetsForCAP that referenced this pull request Sep 25, 2024
zickgraf added a commit to homalg-project/FinSetsForCAP that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant