Skip to content

Add derivation for *AdjunctionMapWithGivenTensorProduct #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohamed-barakat merged 1 commit into from
Oct 17, 2023
Merged

Add derivation for *AdjunctionMapWithGivenTensorProduct #1492

mohamed-barakat merged 1 commit into from
Oct 17, 2023

Conversation

@TKuh
Copy link
Collaborator

@TKuh TKuh commented Oct 12, 2023

and regenerate CartesianCategories.

@TKuh TKuh force-pushed the adjunction_with_given branch from d34de3b to 4d9a9aa Compare October 12, 2023 16:27
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Files Coverage Δ
CartesianCategories/PackageInfo.g 100.00% <100.00%> (ø)
MonoidalCategories/PackageInfo.g 100.00% <100.00%> (ø)
...tricCocartesianCoclosedCategoriesDerivedMethods.gi 79.17% <70.00%> (-0.21%) ⬇️
...mmetricCoclosedMonoidalCategoriesDerivedMethods.gi 82.21% <70.00%> (-0.28%) ⬇️
...ymmetricCartesianClosedCategoriesDerivedMethods.gi 78.64% <63.63%> (-0.37%) ⬇️
...SymmetricClosedMonoidalCategoriesDerivedMethods.gi 86.71% <63.63%> (-0.57%) ⬇️
...recompiled_categories/MatrixCategoryPrecompiled.gi 66.05% <25.00%> (-0.30%) ⬇️

📢 Thoughts on this report? Let us know!.

@TKuh TKuh force-pushed the adjunction_with_given branch from 4d9a9aa to dd49b55 Compare October 17, 2023 09:07
@TKuh TKuh force-pushed the adjunction_with_given branch from dd49b55 to 2251330 Compare October 17, 2023 09:16
@mohamed-barakat
Copy link
Member

mohamed-barakat commented Oct 17, 2023

Could you also please rebase on the current CAP?

Add derivation for *AdjunctionMapWithGivenTensorProduct
cf75f32 
and regenerate CartesianCategories
@TKuh TKuh force-pushed the adjunction_with_given branch from 2251330 to cf75f32 Compare October 17, 2023 09:27
@TKuh TKuh mentioned this pull request Oct 17, 2023
Open
@mohamed-barakat mohamed-barakat merged commit 91f0ae5 into homalg-project:master Oct 17, 2023
@TKuh TKuh deleted the adjunction_with_given branch October 17, 2023 11:28
@mohamed-barakat mohamed-barakat mentioned this pull request Oct 17, 2023
Closed
@zickgraf zickgraf mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohamed-barakat mohamed-barakat mohamed-barakat left review comments

+1 more reviewer

@zickgraf zickgraf zickgraf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TKuh @mohamed-barakat @zickgraf