Warn about unsupported operations in DummyCategory and support "list_of_lists_of_morphisms" in CategoryConstructor

[zickgraf]

No description provided.

[codecov]

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (8be6b6e) 80.68% compared to head (e450cd8) 80.68%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1415   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files         492      492           
  Lines       62461    62468    +7     
=======================================
+ Hits        50398    50404    +6     
- Misses      12063    12064    +1     

Flag	Coverage Δ
ActionsForCAP	64.76% <ø> (ø)
AttributeCategoryForCAP	88.91% <ø> (ø)
CAP	83.91% <88.88%> (+<0.01%)	⬆️
CartesianCategories	93.98% <ø> (ø)
CompilerForCAP	94.25% <ø> (ø)
ComplexesAndFilteredObjectsForCAP	73.68% <ø> (ø)
FreydCategoriesForCAP	81.25% <ø> (ø)
GeneralizedMorphismsForCAP	61.40% <ø> (ø)
GradedModulePresentationsForCAP	44.59% <ø> (ø)
GroupRepresentationsForCAP	72.06% <ø> (ø)
HomologicalAlgebraForCAP	73.21% <ø> (ø)
InternalExteriorAlgebraForCAP	93.08% <ø> (ø)
LinearAlgebraForCAP	66.53% <ø> (ø)
ModulePresentationsForCAP	68.41% <ø> (ø)
ModulesOverLocalRingsForCAP	90.70% <ø> (ø)
MonoidalCategories	89.27% <ø> (ø)
ToricSheaves	21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
CAP/gap/DummyCategory.gi	87.50% <80.00%> (-1.08%)	⬇️
CAP/PackageInfo.g	100.00% <100.00%> (ø)
CAP/gap/CategoryConstructor.gi	94.44% <100.00%> (+0.05%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zickgraf]

@mohamed-barakat This might change some numbers due to "MorphismBetweenDirectSums" etc. now being handled by CategoryConstructor and thus also by ReinterpretationOfCategory.

[mohamed-barakat]

@mohamed-barakat This might change some numbers due to "MorphismBetweenDirectSums" etc. now being handled by CategoryConstructor and thus also by ReinterpretationOfCategory.

Will start a test for CategoricalTowers.

Update: Ah, you already started one.

[mohamed-barakat]

@kamalsaleh

The example file presheaves_of_algebroid.g in FunctorCategories is failing with this error in HigherHomologicalAlgebra/ComplexesCategories:

Error, can only deal with 'integer', 'object', 'morphism', 'list_of_objects', 'list_of_morphisms', 'pair_of_morphisms' at ~/.gap/pkg/HigherHomologicalAlgebra/ComplexesCategories//gap/Categories.gi:210 called from
func( C[i] ) at ~/software/gap/build/gap-4.12.1/lib/coll.gi:663 called from
List( [ 1 .. Length( info.filter_list ) ], function ( j )
      local type;
      type := info.filter_list[j];
      if j = 1 and type = "category" then
          return "presh_cat";
      elif type in [ "integer", "element_of_commutative_ring_of_linear_structure" ] then
          return Concatenation( "i_arg[", String( j ), "]" );
      elif type = "object" then
          return Concatenation( "ObjectDatum( cat, i_arg[", String( j ), "] )[1]" );
      elif type = "morphism" then
          return Concatenation( "MorphismDatum( i_arg[", String( j ), "] )" );
      elif type = "list_of_objects" then
          return Concatenation( "List( i_arg[", String( j ), "], o -> ObjectDatum( cat, o )[1] )" );
      elif type = "list_of_morphisms" then
          return Concatenation( "List( i_arg[", String( j ), "], m -> MorphismDatum( cat, m ) )" );
      elif type = "pair_of_morphisms" then
          return Concatenation( "Pair( ", "MorphismDatum( cat, i_arg[", String( j ), "][1] )", ", MorphismDatum( cat, i_arg[", String( j ), "][2] )", " )" );
      else
          Error( "can only deal with 'integer', 'object', 'morphism', 'list_of_objects', 'list_of_morphisms', 'pair_of_morphisms'" );
      fi;
      return;
  end ) at ~/.gap/pkg/HigherHomologicalAlgebra/ComplexesCategories//gap/Categories.gi:213 called from
create_func( name, CC ) at ~/.gap/pkg/CAP_project/CAP//gap/CategoryConstructor.gi:325 called from
CategoryConstructor( rec(
    name := name,
    category_filter := category_filter,
    category_object_filter := category_object_filter,
    category_morphism_filter := category_morphism_filter,
    commutative_ring_of_linear_category := commutative_ring,
    properties := properties,
    is_computable := false,
    object_constructor := object_constructor,
    object_datum := object_datum,
    morphism_constructor := morphism_constructor,
    morphism_datum := morphism_datum,
    underlying_category_getter_string := "UnderlyingCategory",
    list_of_operations_to_install := list_of_operations_to_install,
    supports_empty_limits := supports_empty_limits,
    create_func_bool := create_func_bool,
    create_func_object := create_func_object,
    create_func_morphism := create_func_morphism ) ) at ~/.gap/pkg/HigherHomologicalAlgebra/ComplexesCategories//gap/Categories.gi:236 called from
COMPLEXES_CATEGORY_BY_COCHAINS_AS_TOWER( cat ) at ~/.gap/pkg/HigherHomologicalAlgebra/ComplexesCategories//gap/Categories.gi:256 called from
...  at presheaves_of_algebroid.g:140