Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added implication IsLinearCategoryOverCommutativeRing => IsAbCategory #1365

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mohamed-barakat
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (62cee38) 79.50% compared to head (fbeb61a) 79.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1365   +/-   ##
=======================================
  Coverage   79.50%   79.50%           
=======================================
  Files         500      500           
  Lines       62495    62496    +1     
=======================================
+ Hits        49689    49690    +1     
  Misses      12806    12806           
Flag Coverage Δ
ActionsForCAP 65.09% <ø> (ø)
AttributeCategoryForCAP 88.61% <ø> (ø)
CAP 82.75% <100.00%> (+<0.01%) ⬆️
CartesianCategories 93.15% <ø> (ø)
CompilerForCAP 94.99% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.68% <ø> (ø)
DeductiveSystemForCAP 25.08% <ø> (ø)
FreydCategoriesForCAP 81.03% <ø> (ø)
GeneralizedMorphismsForCAP 62.57% <ø> (ø)
GradedModulePresentationsForCAP 44.66% <ø> (ø)
GroupRepresentationsForCAP 72.10% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.08% <ø> (ø)
LinearAlgebraForCAP 66.57% <ø> (ø)
ModulePresentationsForCAP 68.76% <ø> (ø)
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 88.56% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
CAP/PackageInfo.g 100.00% <100.00%> (ø)
CAP/gap/CAP.gi 59.03% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zickgraf zickgraf merged commit 0912582 into homalg-project:master Jun 29, 2023
4 checks passed
@zickgraf
Copy link
Member

@kamalsaleh With this, you have to revert the adjustments to the tests in homalg-project/HigherHomologicalAlgebra#158.

@mohamed-barakat mohamed-barakat deleted the devel branch June 29, 2023 13:34
zickgraf added a commit to zickgraf/HigherHomologicalAlgebra that referenced this pull request Jul 2, 2023
This partially reverts commit d6c87f7.
kamalsaleh added a commit to homalg-project/HigherHomologicalAlgebra that referenced this pull request Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add implication IsLinearCategoryOverCommutativeRing => IsAbCategory to CAP
2 participants